Instantiate and destroy v4 update manager with IO thread start/stop.

Instantiate and destroy v4 update manager with IO thread start/stop.

BUG=543161
Committed: https://crrev.com/5bd89ecfdef7dab7ae50070d8ce0c28aeb6863c0
Cr-Commit-Position: refs/heads/master@{#383519}

[vakh (use Gerrit instead), 2016-03-21 23:20:59]

Instantiate/destroy v4 update manager with IO thread start/stop.

[vakh (use Gerrit instead), 2016-03-21 23:22:21]

vakh@chromium.org changed reviewers:
+ kcarattini@chromium.org, nparker@chromium.org

[kcarattini, 2016-03-22 00:41:43]

https://codereview.chromium.org/1821873002/diff/20001/components/safe_browsin...
File components/safe_browsing_db/database_manager.cc (right):

https://codereview.chromium.org/1821873002/diff/20001/components/safe_browsin...
components/safe_browsing_db/database_manager.cc:39: v4_update_protocol_manager_
= V4UpdateProtocolManager::Create(
Why not just put this in the same if statement above?

[vakh (use Gerrit instead), 2016-03-22 01:19:07]

Re-use the if block

[vakh (use Gerrit instead), 2016-03-22 01:21:12]

On 2016/03/22 at 00:41:43, kcarattini wrote:
>
https://codereview.chromium.org/1821873002/diff/20001/components/safe_browsin...
> File components/safe_browsing_db/database_manager.cc (right):
> 
>
https://codereview.chromium.org/1821873002/diff/20001/components/safe_browsin...
> components/safe_browsing_db/database_manager.cc:39:
v4_update_protocol_manager_ = V4UpdateProtocolManager::Create(
> Why not just put this in the same if statement above?

D'oh. Sorry about that. I intended to do that before sending out the CL for
review but forgot. Done now.

[kcarattini, 2016-03-22 01:31:46]

lgtm

[Nathan Parker, 2016-03-24 00:31:09]

lgtm

https://codereview.chromium.org/1821873002/diff/40001/components/safe_browsin...
File components/safe_browsing_db/database_manager.cc (right):

https://codereview.chromium.org/1821873002/diff/40001/components/safe_browsin...
components/safe_browsing_db/database_manager.cc:52: // This cancels all
in-flight update requests.
(There can be only one, ya?)

[vakh (use Gerrit instead), 2016-03-25 23:26:06]

Fix comment.

[vakh (use Gerrit instead), 2016-03-25 23:26:52]

https://codereview.chromium.org/1821873002/diff/40001/components/safe_browsin...
File components/safe_browsing_db/database_manager.cc (right):

https://codereview.chromium.org/1821873002/diff/40001/components/safe_browsin...
components/safe_browsing_db/database_manager.cc:52: // This cancels all
in-flight update requests.
On 2016/03/24 00:31:09, Nathan Parker wrote:
> (There can be only one, ya?)

Done.

[vakh (use Gerrit instead), 2016-03-26 00:52:26]

git fetch && git rebase

[vakh (use Gerrit instead), 2016-03-28 17:26:17]

The CQ bit was checked by vakh@chromium.org

[vakh (use Gerrit instead), 2016-03-28 17:26:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
nparker@chromium.org, kcarattini@chromium.org
Link to the patchset: https://codereview.chromium.org/1821873002/#ps80001
(title: "git fetch && git rebase")

[commit-bot: I haz the power, 2016-03-28 17:26:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821873002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821873002/80001

[commit-bot: I haz the power, 2016-03-28 18:07:10]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-28 18:08:31]

Description was changed from

==========
Instantiate and destroy v4 update manager with IO thread start/stop.

BUG=543161
==========

to

==========
Instantiate and destroy v4 update manager with IO thread start/stop.

BUG=543161

Committed: https://crrev.com/5bd89ecfdef7dab7ae50070d8ce0c28aeb6863c0
Cr-Commit-Position: refs/heads/master@{#383519}
==========

[commit-bot: I haz the power, 2016-03-28 18:08:32]

Patchset 5 (id:??) landed as
https://crrev.com/5bd89ecfdef7dab7ae50070d8ce0c28aeb6863c0
Cr-Commit-Position: refs/heads/master@{#383519}