Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: cc/trees/single_thread_proxy.cc

Issue 1821863002: Hook up ui::Compositor to Display's BeginFrameSource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Display member destruction order Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/single_thread_proxy.h ('k') | components/mus/surfaces/direct_output_surface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/single_thread_proxy.cc
diff --git a/cc/trees/single_thread_proxy.cc b/cc/trees/single_thread_proxy.cc
index 8194f3855d04d2245bec039c53f45a27814ff318..3d991c05fee807cce943357d37ac5b7eea87a110 100644
--- a/cc/trees/single_thread_proxy.cc
+++ b/cc/trees/single_thread_proxy.cc
@@ -73,18 +73,21 @@ void SingleThreadProxy::Start(
CompositorTimingHistory::BROWSER_UMA,
layer_tree_host_->rendering_stats_instrumentation()));
- BeginFrameSource* frame_source = external_begin_frame_source_.get();
- if (!scheduler_settings.throttle_frame_production) {
- // Unthrottled source takes precedence over external sources.
- unthrottled_begin_frame_source_.reset(new BackToBackBeginFrameSource(
- task_runner_provider_->MainThreadTaskRunner()));
- frame_source = unthrottled_begin_frame_source_.get();
- }
- if (!frame_source) {
- synthetic_begin_frame_source_.reset(new SyntheticBeginFrameSource(
- task_runner_provider_->MainThreadTaskRunner(),
- BeginFrameArgs::DefaultInterval()));
- frame_source = synthetic_begin_frame_source_.get();
+ BeginFrameSource* frame_source = nullptr;
+ if (!layer_tree_host_->settings().use_output_surface_begin_frame_source) {
+ frame_source = external_begin_frame_source_.get();
+ if (!scheduler_settings.throttle_frame_production) {
+ // Unthrottled source takes precedence over external sources.
+ unthrottled_begin_frame_source_.reset(new BackToBackBeginFrameSource(
+ task_runner_provider_->MainThreadTaskRunner()));
+ frame_source = unthrottled_begin_frame_source_.get();
+ }
+ if (!frame_source) {
+ synthetic_begin_frame_source_.reset(new SyntheticBeginFrameSource(
+ task_runner_provider_->MainThreadTaskRunner(),
+ BeginFrameArgs::DefaultInterval()));
+ frame_source = synthetic_begin_frame_source_.get();
+ }
}
scheduler_on_impl_thread_ =
@@ -491,6 +494,16 @@ void SingleThreadProxy::CommitVSyncParameters(base::TimeTicks timebase,
synthetic_begin_frame_source_->OnUpdateVSyncParameters(timebase, interval);
}
+void SingleThreadProxy::SetBeginFrameSource(BeginFrameSource* source) {
+ DCHECK(layer_tree_host_->settings().single_thread_proxy_scheduler);
+ // TODO(enne): this overrides any preexisting begin frame source. Those
+ // other sources will eventually be removed and this will be the only path.
+ if (!layer_tree_host_->settings().use_output_surface_begin_frame_source)
+ return;
+ if (scheduler_on_impl_thread_)
+ scheduler_on_impl_thread_->SetBeginFrameSource(source);
+}
+
void SingleThreadProxy::SetEstimatedParentDrawTime(base::TimeDelta draw_time) {
if (scheduler_on_impl_thread_)
scheduler_on_impl_thread_->SetEstimatedParentDrawTime(draw_time);
« no previous file with comments | « cc/trees/single_thread_proxy.h ('k') | components/mus/surfaces/direct_output_surface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698