Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2619)

Unified Diff: cc/surfaces/surface_display_output_surface.cc

Issue 1821863002: Hook up ui::Compositor to Display's BeginFrameSource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Display member destruction order Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/surface_display_output_surface.cc
diff --git a/cc/surfaces/surface_display_output_surface.cc b/cc/surfaces/surface_display_output_surface.cc
index 396f7bb96691f1a8610d5a1962e0b32cf30241d8..260e5cdb60191e673d79ef7d51c8497fa1028faf 100644
--- a/cc/surfaces/surface_display_output_surface.cc
+++ b/cc/surfaces/surface_display_output_surface.cc
@@ -21,7 +21,7 @@ SurfaceDisplayOutputSurface::SurfaceDisplayOutputSurface(
scoped_refptr<ContextProvider> worker_context_provider)
: OutputSurface(std::move(context_provider),
std::move(worker_context_provider)),
- display_client_(NULL),
+ display_client_(nullptr),
factory_(surface_manager, this),
allocator_(allocator) {
factory_.set_needs_sync_points(false);
@@ -41,12 +41,6 @@ SurfaceDisplayOutputSurface::~SurfaceDisplayOutputSurface() {
}
}
-void SurfaceDisplayOutputSurface::ReceivedVSyncParameters(
- base::TimeTicks timebase,
- base::TimeDelta interval) {
- CommitVSyncParameters(timebase, interval);
-}
-
void SurfaceDisplayOutputSurface::SwapBuffers(CompositorFrame* frame) {
gfx::Size frame_size =
frame->delegated_frame_data->render_pass_list.back()->output_rect.size();
@@ -74,10 +68,10 @@ void SurfaceDisplayOutputSurface::SwapBuffers(CompositorFrame* frame) {
bool SurfaceDisplayOutputSurface::BindToClient(OutputSurfaceClient* client) {
DCHECK(client);
DCHECK(display_client_);
+ client_ = client;
factory_.manager()->RegisterSurfaceFactoryClient(allocator_->id_namespace(),
this);
- client_ = client;
// Avoid initializing GL context here, as this should be sharing the
// Display's context.
return display_client_->Initialize();
@@ -109,7 +103,8 @@ void SurfaceDisplayOutputSurface::ReturnResources(
void SurfaceDisplayOutputSurface::SetBeginFrameSource(
BeginFrameSource* begin_frame_source) {
- // TODO(tansell): Hook this up.
+ DCHECK(client_);
+ client_->SetBeginFrameSource(begin_frame_source);
}
void SurfaceDisplayOutputSurface::SwapBuffersComplete(SurfaceDrawStatus drawn) {
« no previous file with comments | « cc/surfaces/surface_display_output_surface.h ('k') | cc/surfaces/surface_display_output_surface_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698