Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1821833003: Remove unused SVGTextMetrics constructor (Closed)

Created:
4 years, 9 months ago by fs
Modified:
4 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused SVGTextMetrics constructor This version of the SVGTextMetrics constructor is no longer used after SVGTextMetrics::measureCharacterRange was removed by https://codereview.chromium.org/1773403002. Committed: https://crrev.com/52fcda05d3a0f66b4850f7af080d297f3010553f Cr-Commit-Position: refs/heads/master@{#382573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
4 years, 9 months ago (2016-03-22 13:17:17 UTC) #2
Stephen Chennney
lgtm, assuming the bots agree.
4 years, 9 months ago (2016-03-22 13:43:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821833003/1
4 years, 9 months ago (2016-03-22 14:47:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 15:22:59 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 15:24:20 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/52fcda05d3a0f66b4850f7af080d297f3010553f
Cr-Commit-Position: refs/heads/master@{#382573}

Powered by Google App Engine
This is Rietveld 408576698