[Mac][Material Design] Update Omnibox dropdown on Mac to MD

[Mac][Material Design] Update Omnibox dropdown on Mac to MD

This cl changes the appearance of the Omnibox dropdown list (background
colors, icons, etc.) to match the Material Design spec.

BUG=589942
r=tapted@chromium.org

Committed: https://crrev.com/7d8ce7003186698ce565f6eb59bf7027a2707f22
Cr-Commit-Position: refs/heads/master@{#390760}

[shrike, 2016-04-27 23:58:45]

Description was changed from

==========
WIP - Update Omnibox dropdown on Mac to Material Design

BUG=589942
==========

to

==========
Update the Mac Omnibox dropdown to Material Design.

BUG=589942
r=tapted@chromium.org
==========

[shrike, 2016-04-27 23:58:45]

shrike@chromium.org changed reviewers:
+ tapted@chromium.org

[shrike, 2016-04-27 23:58:57]

PTAL

[tapted, 2016-04-28 14:29:45]

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:1: // Copyright
2012 The Chromium Authors. All rights reserved.
CL description: the subject line should repeat verbatim on the first line

could you add a summary of the changes in the CL description too? We usually put
sample screenshots of the "after" attached to the bug too -- there's an ancient
chromium-dev post about this -
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/46FC_0rkk40/4MboS...

It would be nice to have the mocks on the bug too, if there's nothing secret
there.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm
(right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm:102:
NSImage* the_image = NSImageFromImageSkia(gfx::CreateVectorIcon(
did we want sRGB for this?

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/star_decoration.mm (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/star_decoration.mm:49: NSImage* theImage;
theImage -> vector_image? Also it should be declared down where it's assigned on
line 62 (or omitted completely, if you like that)

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/star_decoration.mm:59: :
gfx::kChromeIconGrey;
the second half of this ternary if-else isn't needed

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/translate_decoration.mm (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/translate_decoration.mm:33:
vector_icon_color = location_bar_is_dark ? SkColorSetA(SK_ColorWHITE, 0xCC)
This 0xCC appears in a few places, so does kIconSize = 16 -- can we declare them
as a static const member of LocationDecoration perhaps?

And to balance kChromeIconGrey, it would probably be nice to store the full
SkColor for the dark background, rather than just 0xCC.

Or it could even be a protected member function like

// static
SkColor LocationDecoration::GetMaterialIconColor(bool location_bar_is_dark) {
  return ..
}

that would remove some more of the boilerplate. Or perhaps even

NSImage* GetMaterialImageFor(gfx::VectorIconId icon_id, bool
location_bar_is_dark) {
    ..
}

(but you'd probably need both methods since the StarDecoration doesn't fit the
pattern, but it looks like most others do)

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm:132: [[[NSImage alloc]
initWithSize:icon_size] autorelease];
this might fit on the line above now

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:103: const SkColor
kDimTextColor = 0xFF646464;
nit: SkColorSetRGB, to be consistent with the stuff below

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:187: NSFontAttributeName :
FieldFont()
Will this change font sizes for non-material as well? (is that the intention?) I
think only SmallFont received a change based on material.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:450: [incognitoImage_
release];
huhhh Where are the other retained properties released?  Surely this isn't one
big memory leak already.... what am I not seeing o_O.

(maybe this class should be using base/mac/objc_property_releaser.h)

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:468:
base::mac::ObjCCast<OmniboxPopupMatrix>(controlView);
ObjCCastStrict

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:564: if
(ui::MaterialDesignController::IsModeMaterial()) {
this seems subtle - maybe a comment?

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h:83: @property(nonatomic)
BOOL hasDarkTheme;
readonly?

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_separator_view.mm (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_separator_view.mm:7: #include
"base/mac/scoped_nsobject.h"
nit: import

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_separator_view.mm:40: [self
setWantsLayer:YES];
comment about this?

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h:31: static NSColor*
BackgroundColor(BOOL is_dark_theme);
hm - I think constructors come before static methods - had that as a review
comment in one of my own CLs recently :)

Also it's weird seeing an ObjC "BOOL" here - perhaps bool? But BOOL is perhaps
more consistent too for this particular var

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm:56: // Static.
// static

(I guess this is one exception to the "use sentence style")

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm:57: 
remove blank line

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm:1106: if
(!ui::MaterialDesignController::IsModeMaterial()) {
I'm wary of putting this here - did you check all the places that call
`OmniboxViewMac::GetSmallFont`? there might be some surprises.

[shrike, 2016-04-28 16:20:21]

Description was changed from

==========
Update the Mac Omnibox dropdown to Material Design.

BUG=589942
r=tapted@chromium.org
==========

to

==========
[Mac][Mateiral Design] Update Omnibox dropdown on Mac to MD

This cl changes the appearance of the Omnibox dropdown list (background colors,
icons, etc.) to match the Material Design spec.

BUG=589942
r=tapted@chromium.org
==========

[shrike, 2016-04-28 16:21:14]

Description was changed from

==========
[Mac][Mateiral Design] Update Omnibox dropdown on Mac to MD

This cl changes the appearance of the Omnibox dropdown list (background colors,
icons, etc.) to match the Material Design spec.

BUG=589942
r=tapted@chromium.org
==========

to

==========
[Mac][Mateiral Design] Update Omnibox dropdown on Mac to MD

This cl changes the appearance of the Omnibox dropdown list (background
colors, icons, etc.) to match the Material Design spec.

BUG=589942
r=tapted@chromium.org
==========

[shrike, 2016-04-28 21:05:36]

PTAL

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:1: // Copyright
2012 The Chromium Authors. All rights reserved.
On 2016/04/28 14:29:43, tapted wrote:
> CL description: the subject line should repeat verbatim on the first line

Thank you. I will work to make sure that is always the case.

> could you add a summary of the changes in the CL description too?

Please let me know if my summary is adequate (I'm not sure how much detail
you're looking for).

> We usually put
> sample screenshots of the "after" attached to the bug too -- there's an
ancient
> chromium-dev post about this -
>
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/46FC_0rkk40/4MboS...
> 
> It would be nice to have the mocks on the bug too, if there's nothing secret
> there.

OK, I will work on that.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm
(right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm:102:
NSImage* the_image = NSImageFromImageSkia(gfx::CreateVectorIcon(
On 2016/04/28 14:29:43, tapted wrote:
> did we want sRGB for this?

I think no for now. That's because this icon appears within the location bar but
the location bar's background and other colors have not been moved to sRGB.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/star_decoration.mm (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/star_decoration.mm:49: NSImage* theImage;
On 2016/04/28 14:29:44, tapted wrote:
> theImage -> vector_image? Also it should be declared down where it's assigned
on
> line 62 (or omitted completely, if you like that)

Missed cleaning this up after a previous change. Omitted.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/star_decoration.mm:59: :
gfx::kChromeIconGrey;
On 2016/04/28 14:29:44, tapted wrote:
> the second half of this ternary if-else isn't needed

Thank you.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm:132: [[[NSImage alloc]
initWithSize:icon_size] autorelease];
On 2016/04/28 14:29:44, tapted wrote:
> this might fit on the line above now

Almost - the semi-colon end up being over the limit.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:103: const SkColor
kDimTextColor = 0xFF646464;
On 2016/04/28 14:29:44, tapted wrote:
> nit: SkColorSetRGB, to be consistent with the stuff below

Done.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:187: NSFontAttributeName :
FieldFont()
On 2016/04/28 14:29:44, tapted wrote:
> Will this change font sizes for non-material as well? (is that the intention?)
I
> think only SmallFont received a change based on material.

Thank you for catching that.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:450: [incognitoImage_
release];
On 2016/04/28 14:29:44, tapted wrote:
> huhhh Where are the other retained properties released?  Surely this isn't one
> big memory leak already.... what am I not seeing o_O.
> 
> (maybe this class should be using base/mac/objc_property_releaser.h)

Right - I filed https://crbug.com/596715 for this (and assigned it to myself).
My thought was to confirm and fix in a separate pass.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:468:
base::mac::ObjCCast<OmniboxPopupMatrix>(controlView);
On 2016/04/28 14:29:44, tapted wrote:
> ObjCCastStrict

Done.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:564: if
(ui::MaterialDesignController::IsModeMaterial()) {
On 2016/04/28 14:29:44, tapted wrote:
> this seems subtle - maybe a comment?

Done.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h:83: @property(nonatomic)
BOOL hasDarkTheme;
On 2016/04/28 14:29:44, tapted wrote:
> readonly?

Sure.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_separator_view.mm (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_separator_view.mm:7: #include
"base/mac/scoped_nsobject.h"
On 2016/04/28 14:29:44, tapted wrote:
> nit: import

Thank you.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_separator_view.mm:40: [self
setWantsLayer:YES];
On 2016/04/28 14:29:44, tapted wrote:
> comment about this?

Done.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h:31: static NSColor*
BackgroundColor(BOOL is_dark_theme);
On 2016/04/28 14:29:44, tapted wrote:
> hm - I think constructors come before static methods - had that as a review
> comment in one of my own CLs recently :)
> 
> Also it's weird seeing an ObjC "BOOL" here - perhaps bool? But BOOL is perhaps
> more consistent too for this particular var

Done.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm:56: // Static.
On 2016/04/28 14:29:44, tapted wrote:
> // static
> 
> (I guess this is one exception to the "use sentence style")

Done.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm:57: 
On 2016/04/28 14:29:44, tapted wrote:
> remove blank line

Done.

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm (right):

https://codereview.chromium.org/1821823004/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm:1106: if
(!ui::MaterialDesignController::IsModeMaterial()) {
On 2016/04/28 14:29:44, tapted wrote:
> I'm wary of putting this here - did you check all the places that call
> `OmniboxViewMac::GetSmallFont`? there might be some surprises.

It's only called by SmallFont() in omnibox_popup_cell.mm. SmallFont() in turn is
only called in one place.

[tapted, 2016-04-28 23:57:51]

lgtm % nits

And yeah - those existing `retain` properties really do look like memory
leaks... but then the more troubling concern is why they didn't already get
picked up by a sanitizer  (maybe valgrind would have caught them, but that's
deprecated and it relies on there actually being test coverage)

https://codereview.chromium.org/1821823004/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h (right):

https://codereview.chromium.org/1821823004/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h:1: // Copyright
(c) 2010 The Chromium Authors. All rights reserved.
CL description+subject: fix typo: "Mateiral" -> "Material"

https://codereview.chromium.org/1821823004/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h:94: NSImage*
GetMaterialIcon(bool location_bar_is_dark);
nit: these methods can all be const methods  (GetFoo() methods that are neither
const nor static tend to raise eyebrows)

https://codereview.chromium.org/1821823004/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm (right):

https://codereview.chromium.org/1821823004/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm:56: // static.
nit: no fullstop. "// static" is just how it always appears in Chrome for some
reason

https://codereview.chromium.org/1821823004/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm:57: NSColor*
OmniboxPopupViewMac::BackgroundColor(bool is_dark_theme) {
nit: move below destructor

[shrike, 2016-04-29 17:47:38]

Description was changed from

==========
[Mac][Mateiral Design] Update Omnibox dropdown on Mac to MD

This cl changes the appearance of the Omnibox dropdown list (background
colors, icons, etc.) to match the Material Design spec.

BUG=589942
r=tapted@chromium.org
==========

to

==========
[Mac][Material Design] Update Omnibox dropdown on Mac to MD

This cl changes the appearance of the Omnibox dropdown list (background
colors, icons, etc.) to match the Material Design spec.

BUG=589942
r=tapted@chromium.org
==========

[shrike, 2016-04-29 18:47:52]

https://codereview.chromium.org/1821823004/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h (right):

https://codereview.chromium.org/1821823004/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h:1: // Copyright
(c) 2010 The Chromium Authors. All rights reserved.
On 2016/04/28 23:57:51, tapted wrote:
> CL description+subject: fix typo: "Mateiral" -> "Material"

Done.

https://codereview.chromium.org/1821823004/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h:94: NSImage*
GetMaterialIcon(bool location_bar_is_dark);
On 2016/04/28 23:57:51, tapted wrote:
> nit: these methods can all be const methods  (GetFoo() methods that are
neither
> const nor static tend to raise eyebrows)

Done.

https://codereview.chromium.org/1821823004/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm (right):

https://codereview.chromium.org/1821823004/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm:56: // static.
On 2016/04/28 23:57:51, tapted wrote:
> nit: no fullstop. "// static" is just how it always appears in Chrome for some
> reason

OK.

https://codereview.chromium.org/1821823004/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm:57: NSColor*
OmniboxPopupViewMac::BackgroundColor(bool is_dark_theme) {
On 2016/04/28 23:57:51, tapted wrote:
> nit: move below destructor

Done.

[shrike, 2016-04-29 18:48:00]

The CQ bit was checked by shrike@chromium.org

[shrike, 2016-04-29 18:48:00]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/1821823004/#ps120001
(title: "Fix nits, adjust colors to spec, git cl format.")

[commit-bot: I haz the power, 2016-04-29 18:48:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821823004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821823004/120001

[commit-bot: I haz the power, 2016-04-29 19:03:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 19:03:56]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[shrike, 2016-04-29 19:09:55]

The CQ bit was checked by shrike@chromium.org

[shrike, 2016-04-29 19:09:56]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/1821823004/#ps140001
(title: "Fix compile bug.")

[commit-bot: I haz the power, 2016-04-29 19:10:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821823004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821823004/140001

[commit-bot: I haz the power, 2016-04-29 19:22:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 19:22:42]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shrike, 2016-04-29 20:22:23]

The CQ bit was checked by shrike@chromium.org

[shrike, 2016-04-29 20:22:23]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/1821823004/#ps160001
(title: "Fix tests.")

[commit-bot: I haz the power, 2016-04-29 20:22:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821823004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821823004/160001

[commit-bot: I haz the power, 2016-04-29 21:11:32]

Description was changed from

==========
[Mac][Material Design] Update Omnibox dropdown on Mac to MD

This cl changes the appearance of the Omnibox dropdown list (background
colors, icons, etc.) to match the Material Design spec.

BUG=589942
r=tapted@chromium.org
==========

to

==========
[Mac][Material Design] Update Omnibox dropdown on Mac to MD

This cl changes the appearance of the Omnibox dropdown list (background
colors, icons, etc.) to match the Material Design spec.

BUG=589942
r=tapted@chromium.org
==========

[commit-bot: I haz the power, 2016-04-29 21:11:33]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-04-30 17:29:01]

Patchset 9 (id:??) landed as
https://crrev.com/7d8ce7003186698ce565f6eb59bf7027a2707f22
Cr-Commit-Position: refs/heads/master@{#390760}

[commit-bot: I haz the power, 2016-04-30 18:02:38]

Description was changed from

==========
[Mac][Material Design] Update Omnibox dropdown on Mac to MD

This cl changes the appearance of the Omnibox dropdown list (background
colors, icons, etc.) to match the Material Design spec.

BUG=589942
r=tapted@chromium.org
==========

to

==========
[Mac][Material Design] Update Omnibox dropdown on Mac to MD

This cl changes the appearance of the Omnibox dropdown list (background
colors, icons, etc.) to match the Material Design spec.

BUG=589942
r=tapted@chromium.org

Committed: https://crrev.com/7d8ce7003186698ce565f6eb59bf7027a2707f22
Cr-Commit-Position: refs/heads/master@{#390760}
==========