chrome/browser/media/router/media_router.mojom - Issue 1821823002: [Media Router] Conditionally enable mDNS on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/media_router.mojom

Issue 1821823002: [Media Router] Conditionally enable mDNS on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed compile and build dependency issues Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/router/media_route_provider_util.cc ('K') | « chrome/browser/media/router/media_router.gypi ('k') | chrome/browser/media/router/media_router_mojo_impl.h » ('j') | chrome/browser/media/router/media_router_mojo_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/media_router.mojom

diff --git a/chrome/browser/media/router/media_router.mojom b/chrome/browser/media/router/media_router.mojom

index bb9beabbceed922b65120ceecf16ac6a6382eee8..ed8bc6b9e76c0f539ea7d2d88f53dd97299f22c9 100644

--- a/chrome/browser/media/router/media_router.mojom

+++ b/chrome/browser/media/router/media_router.mojom

@@ -281,6 +281,11 @@ interface MediaRouteProvider {

// |route_id| has been closed (via .close(), garbage collection or

// navigation).

DetachRoute(string route_id);

+ // Enables mDNS discovery. No-ops if mDNS discovery is already enabled.

mark a. foltz 2016/03/24 22:59:33 Nit: s/no-ops/no-op/

btolsch 2016/03/25 04:40:50 Done.

+ // Calling this will trigger a firewall prompt on Windows if there is not

+ // already a firewall rule for mDNS.

+ EnableMdnsDiscovery();

};

// Interface for a service which observes state changes across media