[Media Router] Conditionally enable mDNS on Windows.

chrome/browser/media/router/media_router_mojo_impl.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_MOJO_IMPL_H_
 #define CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_MOJO_IMPL_H_
 
 #include <stdint.h>
 
 #include <deque>
@@ skipping 80 matching lines @@
   void DetachRoute(const MediaRoute::Id& route_id) override;
   void SendRouteMessage(const MediaRoute::Id& route_id,
                         const std::string& message,
                         const SendRouteMessageCallback& callback) override;
   void SendRouteBinaryMessage(
       const MediaRoute::Id& route_id,
       scoped_ptr<std::vector<uint8_t>> data,
       const SendRouteMessageCallback& callback) override;
   void AddIssue(const Issue& issue) override;
   void ClearIssue(const Issue::Id& issue_id) override;
+  bool should_enable_mdns_discovery() const override;
+  void EnsureMdnsDiscoveryEnabled() override;
 
   const std::string& media_route_provider_extension_id() const {
     return media_route_provider_extension_id_;
   }
 
   void set_instance_id_for_test(const std::string& instance_id) {
     instance_id_ = instance_id;
   }
 
  private:
@@ skipping 202 matching lines @@
   void AttemptWakeEventPage();
 
   // Sets the reason why we are attempting to wake the extension.  Since
   // multiple tasks may be enqueued for execution each time the extension runs,
   // we record the first such reason.
   void SetWakeReason(MediaRouteProviderWakeReason reason);
 
   // Clears the wake reason after the extension has been awoken.
   void ClearWakeReason();
 
+  void EnableMdnsFromFirewallCheck(bool firewall_can_use_local_ports);
+
   // Pending requests queued to be executed once component extension
   // becomes ready.
   std::deque<base::Closure> pending_requests_;
 
   base::ScopedPtrHashMap<MediaSource::Id, scoped_ptr<MediaSinksQuery>>
       sinks_queries_;
 
   base::ScopedPtrHashMap<MediaSource::Id, scoped_ptr<MediaRoutesQuery>>
       routes_queries_;
 
@@ skipping 41 matching lines @@
   int wakeup_attempt_count_ = 0;
 
   // Records the current reason the extension is being woken up.  Is set to
   // MediaRouteProviderWakeReason::TOTAL_COUNT if there is no pending reason.
   MediaRouteProviderWakeReason current_wake_reason_;
 
   // A flag to ensure that we record the provider version once, during the
   // initial event page wakeup attempt.
   bool provider_version_was_recorded_ = false;
 
+  // A flag to ensure that mDNS discovery is only enabled on Windows when there
+  // will be appropriate context for the user to associate a firewall prompt
+  // with Media Router. This can be set to |true| earlier if we know that a
+  // prompt will not occur.
+  bool should_enable_mdns_discovery_ = true;

[imcheng, 2016/03/25 06:26:30]

I would prefer that we define this value to be false for Windows here rather
than in the constructor.

[btolsch, 2016/03/25 18:57:04]

Done.

+
   base::WeakPtrFactory<MediaRouterMojoImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaRouterMojoImpl);
 };
 
 }  // namespace media_router
 
 #endif  // CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_MOJO_IMPL_H_