Ensure CreateDataProperty works correctly on TypedArrays

src/objects.cc

Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 026f01d826542960581dc4c58a39e76b57a07184..fb1535b457c07db6394aa5789c0ce5e8320a2381 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -6685,7 +6685,9 @@ Maybe<bool> JSObject::CreateDataProperty(LookupIterator* it,
   Isolate* isolate = receiver->GetIsolate();
 
   if (it->IsFound()) {
-    if (!it->IsConfigurable()) {
+    Maybe<PropertyAttributes> attributes = GetPropertyAttributes(it);
+    MAYBE_RETURN(attributes, Nothing<bool>());
+    if (!(attributes.FromJust() & DONT_DELETE)) {

[adamk, 2016/04/05 00:04:32]

Sadly, because V8 predates ES5, DONT_DELETE is the opposite of IsConfigurable,
so you need to remove the leading '!'. This is usually spelled:

if ((attributes.FromJust() & DONT_DELETE) != 0) { ... }

[Dan Ehrenberg, 2016/04/05 00:48:39]

Fixed

       RETURN_FAILURE(
           isolate, should_throw,
           NewTypeError(MessageTemplate::kRedefineDisallowed, it->GetName()));