content/browser/accessibility/browser_accessibility_win.cc - Issue 1821723002: Exposed the children of elements with role textbox in order to make rich text information available…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_win.cc

Issue 1821723002: Exposed the children of elements with role textbox in order to make rich text information available… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/accessibility/browser_accessibility.cc ('K') | « content/browser/accessibility/browser_accessibility.cc ('k') | third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_win.cc

diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc

index cb52d207c43c30cca36a8957a393b12cfcc7d3c6..d68475f88bf9be1f872f958272e5725edb97f04e 100644

--- a/content/browser/accessibility/browser_accessibility_win.cc

+++ b/content/browser/accessibility/browser_accessibility_win.cc

@@ -4075,8 +4075,7 @@ void BrowserAccessibilityWin::GetSelectionOffsets(

int* selection_start, int* selection_end) const {

DCHECK(selection_start && selection_end);

- if (HasState(ui::AX_STATE_EDITABLE) &&

- !HasState(ui::AX_STATE_RICHLY_EDITABLE) &&

+ if (IsSimpleTextControl() &&

GetIntAttribute(ui::AX_ATTR_TEXT_SEL_START, selection_start) &&

dmazzoni 2016/03/21 17:04:02 Will these be set on rich text fields too? Or is i

GetIntAttribute(ui::AX_ATTR_TEXT_SEL_END, selection_end)) {

return;