Exposed the children of elements with role textbox in order to make rich text information available…

Exposed the children of elements with role textbox in order to make rich text information available to Windows screen readers.

If we have an HTML element with role="textbox" we correctly assign it an IA role of ROLE_SYSTEM_TEXT. This is the same as what FireFox does.
However, contrary to an <input> or <textarea> element, we should expose its children so that any rich text information would be available to Windows screen readers.
Note that we also keep exposing a flatten representation of the children's text in the value attribute because Jaws and older versions of VoiceOver require it.
BUG=542998
TESTED:browser tests, Blink layout tests, manually with Jaws and NVDA with <input>, content editable and content editable with role="textbox"
R=dmazzoni@chromium.org

Committed: https://crrev.com/9a702688af0b856d52e96f1ce9b5346714ce8985
Cr-Commit-Position: refs/heads/master@{#382526}

Committed: https://crrev.com/b891708b42ec5219d0c15f9e93b62b477116be10
Cr-Commit-Position: refs/heads/master@{#383565}

[dmazzoni, 2016-03-21 17:04:02]

Might need to update some tests, but otherwise lgtm

https://codereview.chromium.org/1821723002/diff/1/content/browser/accessibili...
File content/browser/accessibility/browser_accessibility.cc (right):

https://codereview.chromium.org/1821723002/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility.cc:456: // Some screen
readers like Jaws and older versions of VoiceOver require
Nit: put the comment above or below. Comments in the
middle of an expression can hurt readability.

https://codereview.chromium.org/1821723002/diff/1/content/browser/accessibili...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/1821723002/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility_win.cc:4079:
GetIntAttribute(ui::AX_ATTR_TEXT_SEL_START, selection_start) &&
Will these be set on rich text fields too? Or is it handled elsewhere?

[blink-reviews, 2016-03-21 17:35:15]

Might need to update some tests, but otherwise lgtm
>
> I added a new test instead.
It's clearer.
>
>
https://codereview.chromium.org/1821723002/diff/1/content/browser/accessibili...
> File content/browser/accessibility/browser_accessibility.cc (right):
>
>
https://codereview.chromium.org/1821723002/diff/1/content/browser/accessibili...
> content/browser/accessibility/browser_accessibility.cc:456: // Some
> screen readers like Jaws and older versions of VoiceOver require
> Nit: put the comment above or below. Comments in the
> middle of an expression can hurt readability.
>
>
https://codereview.chromium.org/1821723002/diff/1/content/browser/accessibili...
> File content/browser/accessibility/browser_accessibility_win.cc (right):
>
>
https://codereview.chromium.org/1821723002/diff/1/content/browser/accessibili...
> content/browser/accessibility/browser_accessibility_win.cc:4079:
> GetIntAttribute(ui::AX_ATTR_TEXT_SEL_START, selection_start) &&
> Will these be set on rich text fields too? Or is it handled elsewhere?

Yes, they will be, but we don't want NVDA to use them because it's going 
to lose rich text information. We have to let it use the 
IAccessibleHyperlink and IA2 hypertext APIs instead.

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2016-03-21 17:35:16]

Might need to update some tests, but otherwise lgtm
>
> I added a new test instead.
It's clearer.
>
>
https://codereview.chromium.org/1821723002/diff/1/content/browser/accessibili...
> File content/browser/accessibility/browser_accessibility.cc (right):
>
>
https://codereview.chromium.org/1821723002/diff/1/content/browser/accessibili...
> content/browser/accessibility/browser_accessibility.cc:456: // Some
> screen readers like Jaws and older versions of VoiceOver require
> Nit: put the comment above or below. Comments in the
> middle of an expression can hurt readability.
>
>
https://codereview.chromium.org/1821723002/diff/1/content/browser/accessibili...
> File content/browser/accessibility/browser_accessibility_win.cc (right):
>
>
https://codereview.chromium.org/1821723002/diff/1/content/browser/accessibili...
> content/browser/accessibility/browser_accessibility_win.cc:4079:
> GetIntAttribute(ui::AX_ATTR_TEXT_SEL_START, selection_start) &&
> Will these be set on rich text fields too? Or is it handled elsewhere?

Yes, they will be, but we don't want NVDA to use them because it's going 
to lose rich text information. We have to let it use the 
IAccessibleHyperlink and IA2 hypertext APIs instead.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nektarios, 2016-03-21 19:25:46]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-21 19:26:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821723002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821723002/20001

[commit-bot: I haz the power, 2016-03-21 20:17:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 20:17:50]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[nektarios, 2016-03-22 00:12:55]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 00:13:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821723002/40001

[commit-bot: I haz the power, 2016-03-22 01:16:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 01:16:58]

Dry run: Try jobs failed on following builders:
  linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)

[nektarios, 2016-03-22 04:55:33]

Description was changed from

==========
Exposed the children of elements with role textbox in order to make rich text
information available to Windows screen readers.

If we have an HTML element with role="textbox" we correctly assign it an IA role
of ROLE_SYSTEM_TEXT. This is the same as what FireFox does.
However, contrary to an <input> or <textarea> element, we should expose its
children so that any rich text information would be available to Windows screen
readers.
Note that we also keep exposing a flatten representation of the children's text
in the value attribute because Jaws and older versions of VoiceOver require it.
BUG=542998
TESTED:browser tests, manually with Jaws and NVDA with <input>, content editable
and content editable with role="textbox"
R=dmazzoni@chromium.org
==========

to

==========
Exposed the children of elements with role textbox in order to make rich text
information available to Windows screen readers.

If we have an HTML element with role="textbox" we correctly assign it an IA role
of ROLE_SYSTEM_TEXT. This is the same as what FireFox does.
However, contrary to an <input> or <textarea> element, we should expose its
children so that any rich text information would be available to Windows screen
readers.
Note that we also keep exposing a flatten representation of the children's text
in the value attribute because Jaws and older versions of VoiceOver require it.
BUG=542998
TESTED:browser tests, Blink layout tests, manually with Jaws and NVDA with
<input>, content editable and content editable with role="textbox"
R=dmazzoni@chromium.org
==========

[nektarios, 2016-03-22 05:31:18]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2016-03-22 05:31:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1821723002/#ps60001
(title: "Fixed test expectations.")

[commit-bot: I haz the power, 2016-03-22 05:31:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821723002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821723002/60001

[commit-bot: I haz the power, 2016-03-22 07:34:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-22 07:36:04]

Description was changed from

==========
Exposed the children of elements with role textbox in order to make rich text
information available to Windows screen readers.

If we have an HTML element with role="textbox" we correctly assign it an IA role
of ROLE_SYSTEM_TEXT. This is the same as what FireFox does.
However, contrary to an <input> or <textarea> element, we should expose its
children so that any rich text information would be available to Windows screen
readers.
Note that we also keep exposing a flatten representation of the children's text
in the value attribute because Jaws and older versions of VoiceOver require it.
BUG=542998
TESTED:browser tests, Blink layout tests, manually with Jaws and NVDA with
<input>, content editable and content editable with role="textbox"
R=dmazzoni@chromium.org
==========

to

==========
Exposed the children of elements with role textbox in order to make rich text
information available to Windows screen readers.

If we have an HTML element with role="textbox" we correctly assign it an IA role
of ROLE_SYSTEM_TEXT. This is the same as what FireFox does.
However, contrary to an <input> or <textarea> element, we should expose its
children so that any rich text information would be available to Windows screen
readers.
Note that we also keep exposing a flatten representation of the children's text
in the value attribute because Jaws and older versions of VoiceOver require it.
BUG=542998
TESTED:browser tests, Blink layout tests, manually with Jaws and NVDA with
<input>, content editable and content editable with role="textbox"
R=dmazzoni@chromium.org

Committed: https://crrev.com/9a702688af0b856d52e96f1ce9b5346714ce8985
Cr-Commit-Position: refs/heads/master@{#382526}
==========

[commit-bot: I haz the power, 2016-03-22 07:36:05]

Patchset 4 (id:??) landed as
https://crrev.com/9a702688af0b856d52e96f1ce9b5346714ce8985
Cr-Commit-Position: refs/heads/master@{#382526}

[blundell, 2016-03-22 10:48:29]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1823053002/ by blundell@chromium.org.

The reason for reverting is: Seeing if this patch is responsible for Win7
browser_tests timeouts that seem like they could be related, e.g. the following
(note that the error output at least from my POV is not illuminating; the test
then times out).

ContentSettingsExceptionAreaWebUITest.testOpenContentSettingsExceptionArea (run
#1):
[ RUN      ]
ContentSettingsExceptionAreaWebUITest.testOpenContentSettingsExceptionArea
[1480:4536:0322/031442:WARNING:histogram_base.cc(131)] 2 histograms were created
before reporting was enabled.
[4836:2768:0322/031445:WARNING:histogram_base.cc(131)] 2 histograms were created
before reporting was enabled.
[1480:4536:0322/031446:ERROR:shell.cc(302)] Error: Instance: exe:chrome
attempting to register an instance for a process it created for target:
exe:chrome_renderer without the mojo:shell{client_process} capability class.
[3016:3588:0322/031447:WARNING:histogram_base.cc(131)] 2 histograms were created
before reporting was enabled.
[1480:4536:0322/031448:ERROR:shell.cc(302)] Error: Instance: exe:chrome
attempting to register an instance for a process it created for target:
exe:chrome_renderer without the mojo:shell{client_process} capability class.
[2800:3724:0322/031450:WARNING:histogram_base.cc(131)] 2 histograms were created
before reporting was enabled.
[1480:4536:0322/031453:WARNING:CONSOLE(0)] "/deep/ combinator is deprecated. See
https://www.chromestatus.com/features/6750456638341120 for more details.",
source:  (0)
[2800:3724:0322/031456:ERROR:singleton_hwnd.cc(34)] Cannot create windows on
non-UI thread!
[1480:4536:0322/031458:INFO:CONSOLE(1180)] "Running TestCase
ContentSettingsExceptionAreaWebUITest.MAYBE_testOpenContentSettingsExceptionArea",
source: test_api.js (1180)

Example failing run:

https://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20...

Will reland if this revert doesn't fix the problem..

[newt (away), 2016-03-23 02:31:31]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1825733002/ by newt@chromium.org.

The reason for reverting is:
DumpAccessibilityTreeTest.AccessibilityAriaTextboxWithRichText is now failing on
most Android bots. See crbug.com/597157.

[nektarios, 2016-03-23 07:23:36]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2016-03-23 07:23:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1821723002/#ps80001
(title: "Updated test expectations for Android.")

[commit-bot: I haz the power, 2016-03-23 07:23:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821723002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821723002/80001

[commit-bot: I haz the power, 2016-03-23 09:52:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 09:52:36]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nektarios, 2016-03-28 18:30:19]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2016-03-28 18:30:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1821723002/#ps100001
(title: "Disabled Android test.")

[commit-bot: I haz the power, 2016-03-28 18:30:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821723002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821723002/100001

[commit-bot: I haz the power, 2016-03-28 21:21:18]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-28 21:22:25]

Description was changed from

==========
Exposed the children of elements with role textbox in order to make rich text
information available to Windows screen readers.

If we have an HTML element with role="textbox" we correctly assign it an IA role
of ROLE_SYSTEM_TEXT. This is the same as what FireFox does.
However, contrary to an <input> or <textarea> element, we should expose its
children so that any rich text information would be available to Windows screen
readers.
Note that we also keep exposing a flatten representation of the children's text
in the value attribute because Jaws and older versions of VoiceOver require it.
BUG=542998
TESTED:browser tests, Blink layout tests, manually with Jaws and NVDA with
<input>, content editable and content editable with role="textbox"
R=dmazzoni@chromium.org

Committed: https://crrev.com/9a702688af0b856d52e96f1ce9b5346714ce8985
Cr-Commit-Position: refs/heads/master@{#382526}
==========

to

==========
Exposed the children of elements with role textbox in order to make rich text
information available to Windows screen readers.

If we have an HTML element with role="textbox" we correctly assign it an IA role
of ROLE_SYSTEM_TEXT. This is the same as what FireFox does.
However, contrary to an <input> or <textarea> element, we should expose its
children so that any rich text information would be available to Windows screen
readers.
Note that we also keep exposing a flatten representation of the children's text
in the value attribute because Jaws and older versions of VoiceOver require it.
BUG=542998
TESTED:browser tests, Blink layout tests, manually with Jaws and NVDA with
<input>, content editable and content editable with role="textbox"
R=dmazzoni@chromium.org

Committed: https://crrev.com/9a702688af0b856d52e96f1ce9b5346714ce8985
Cr-Commit-Position: refs/heads/master@{#382526}

Committed: https://crrev.com/b891708b42ec5219d0c15f9e93b62b477116be10
Cr-Commit-Position: refs/heads/master@{#383565}
==========

[commit-bot: I haz the power, 2016-03-28 21:22:26]

Patchset 6 (id:??) landed as
https://crrev.com/b891708b42ec5219d0c15f9e93b62b477116be10
Cr-Commit-Position: refs/heads/master@{#383565}