Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1500)

Unified Diff: docs/mojo_in_chromium.md

Issue 1821713003: Fix sample code in Mojo-in-Chromium markdown docs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/mojo_in_chromium.md
diff --git a/docs/mojo_in_chromium.md b/docs/mojo_in_chromium.md
index 9ec5588e4376ea99f84b5d9562aa91348911e521..f6b555dfe8ce6c7b18877e143f2f63a2b959e8c8 100644
--- a/docs/mojo_in_chromium.md
+++ b/docs/mojo_in_chromium.md
@@ -265,9 +265,8 @@ We can build a simple browser-side `FrobinatorImpl` service that has access to a
#include "base/macros.h"
#include "components/frob/public/interfaces/frobinator.mojom.h"
#include "content/public/browser/browser_context.h"
-#inlcude "mojo/public/cpp/system/interface_request.h"
-#inlcude "mojo/public/cpp/system/message_pipe.h"
-#inlcude "mojo/public/cpp/system/strong_binding.h"
+#include "mojo/public/cpp/system/interface_request.h"
+#include "mojo/public/cpp/system/strong_binding.h"
namespace frob {
@@ -282,8 +281,7 @@ class FrobinatorImpl : public mojom::Frobinator {
static void Create(content::BrowserContext* context,
mojo::InterfaceRequest<mojom::Frobinator> request) {
Ken Rockot(use gerrit already) 2016/03/21 17:13:43 optional nit: We actually have an alias for reques
// See comment below for why this doesn't leak.
- new FrobinatorImpl(context,
- mojo::MakeRequest<mojom::Frobinator>(std::move(pipe)));
+ new FrobinatorImpl(context, std::move(request));
}
private:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698