Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1821713003: Fix sample code in Mojo-in-Chromium markdown docs (Closed)

Created:
4 years, 9 months ago by James Cook
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix sample code in Mojo-in-Chromium markdown docs It looks like an old version of the code used MessagePipe. BUG=none TEST=none Committed: https://crrev.com/962c4f96a3bdc800c6632629b92fb62488051c58 Cr-Commit-Position: refs/heads/master@{#382385}

Patch Set 1 #

Total comments: 1

Patch Set 2 : interfacerequest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M docs/mojo_in_chromium.md View 1 3 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
James Cook
Ken, PTAL
4 years, 9 months ago (2016-03-21 17:08:29 UTC) #2
Ken Rockot(use gerrit already)
Oops, nice catch. LGTM https://codereview.chromium.org/1821713003/diff/1/docs/mojo_in_chromium.md File docs/mojo_in_chromium.md (right): https://codereview.chromium.org/1821713003/diff/1/docs/mojo_in_chromium.md#newcode282 docs/mojo_in_chromium.md:282: mojo::InterfaceRequest<mojom::Frobinator> request) { optional nit: ...
4 years, 9 months ago (2016-03-21 17:13:43 UTC) #3
James Cook
Ken, please take a second look.
4 years, 9 months ago (2016-03-21 17:38:53 UTC) #4
Ken Rockot(use gerrit already)
Thanks! LGTM
4 years, 9 months ago (2016-03-21 18:11:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821713003/20001
4 years, 9 months ago (2016-03-21 20:15:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 20:59:55 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 21:01:29 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/962c4f96a3bdc800c6632629b92fb62488051c58
Cr-Commit-Position: refs/heads/master@{#382385}

Powered by Google App Engine
This is Rietveld 408576698