Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: runtime/bin/secure_socket_macos.cc

Issue 1821693003: Try to fix Mac build (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/secure_socket_macos.cc
diff --git a/runtime/bin/secure_socket_macos.cc b/runtime/bin/secure_socket_macos.cc
index 2df25e140afea60f0b26d882f1a818e14a0db78d..7b0dbd42c450f90f770022be21a4387a54b15874 100644
--- a/runtime/bin/secure_socket_macos.cc
+++ b/runtime/bin/secure_socket_macos.cc
@@ -1047,9 +1047,10 @@ static char* GetNameFromCert(SecCertificateRef certificate,
void FUNCTION_NAME(X509_Subject)(Dart_NativeArguments args) {
SecCertificateRef certificate = GetX509Certificate(args);
- char* subject_name = GetNameFromCert(certificate,
- kSecOIDX509V1SubjectName,
- kSecOIDCommonName);
+ char* subject_name = GetNameFromCert(
+ certificate,
+ kSecOIDX509V1SubjectName,
+ reinterpret_cast<CFStringRef>(kSecOIDCommonName));
if (subject_name == NULL) {
Dart_ThrowException(DartUtils::NewDartArgumentError(
"X509.subject failed to find issuer's common name."));
@@ -1061,9 +1062,10 @@ void FUNCTION_NAME(X509_Subject)(Dart_NativeArguments args) {
void FUNCTION_NAME(X509_Issuer)(Dart_NativeArguments args) {
SecCertificateRef certificate = GetX509Certificate(args);
- char* issuer_name = GetNameFromCert(certificate,
- kSecOIDX509V1IssuerName,
- kSecOIDCommonName);
+ char* issuer_name = GetNameFromCert(
+ certificate,
+ kSecOIDX509V1IssuerName,
+ reinterpret_cast<CFStringRef>(kSecOIDCommonName));
if (issuer_name == NULL) {
Dart_ThrowException(DartUtils::NewDartArgumentError(
"X509.issuer failed to find issuer's common name."));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698