Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1821663002:
[Interpreter] Rebuild dispatch table when FLAG_trace_ignition_codegen is enabled. (Closed)
|
Created:
4 years, 9 months ago by Stefano Sanfilippo Modified:
4 years, 9 months ago Reviewers:
rmcilroy CC:
v8-reviews_googlegroups.com, oth, rmcilroy Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Interpreter] Rebuild dispatch table when FLAG_trace_ignition_codegen is enabled.
Otherwise, no handler would be dumped when using a snapshot.
BUG=v8:4280
LOG=N
Committed: https://crrev.com/0a4820d01ef4b109bed02cc0c8e003a8f296c2aa
Cr-Commit-Position: refs/heads/master@{#34990}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Comment updated. #
Total comments: 1
Patch Set 3 : #Messages
Total messages: 19 (10 generated)
ssanfilippo@chromium.org changed reviewers: + rmcilroy@chromium.org
Description was changed from ========== [Interpreter] Rebuild dispatch table when FLAG_trace_ignition_codegen. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Rebuild dispatch table when FLAG_trace_ignition_codegen is enabled. BUG=v8:4280 LOG=N ==========
Description was changed from ========== [Interpreter] Rebuild dispatch table when FLAG_trace_ignition_codegen is enabled. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Rebuild dispatch table when FLAG_trace_ignition_codegen is enabled. Otherwise, no handler is dumped when using a snapshot. BUG=v8:4280 LOG=N ==========
Description was changed from ========== [Interpreter] Rebuild dispatch table when FLAG_trace_ignition_codegen is enabled. Otherwise, no handler is dumped when using a snapshot. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Rebuild dispatch table when FLAG_trace_ignition_codegen is enabled. Otherwise, no handler would be dumped when using a snapshot. BUG=v8:4280 LOG=N ==========
https://codereview.chromium.org/1821663002/diff/1/src/interpreter/interpreter.cc File src/interpreter/interpreter.cc (right): https://codereview.chromium.org/1821663002/diff/1/src/interpreter/interpreter... src/interpreter/interpreter.cc:115: // Regenerate table to add bytecode tracing operations. Please update this comment.
https://codereview.chromium.org/1821663002/diff/1/src/interpreter/interpreter.cc File src/interpreter/interpreter.cc (right): https://codereview.chromium.org/1821663002/diff/1/src/interpreter/interpreter... src/interpreter/interpreter.cc:115: // Regenerate table to add bytecode tracing operations. On 2016/03/21 16:05:46, rmcilroy wrote: > Please update this comment. Done.
LGTM https://codereview.chromium.org/1821663002/diff/20001/src/interpreter/interpr... File src/interpreter/interpreter.cc (right): https://codereview.chromium.org/1821663002/diff/20001/src/interpreter/interpr... src/interpreter/interpreter.cc:116: // and/or dump the assembly code generated by TurboFan. /a/and/or dump/or to print/
The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821663002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821663002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ssanfilippo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rmcilroy@chromium.org Link to the patchset: https://codereview.chromium.org/1821663002/#ps40001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821663002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821663002/40001
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Rebuild dispatch table when FLAG_trace_ignition_codegen is enabled. Otherwise, no handler would be dumped when using a snapshot. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Rebuild dispatch table when FLAG_trace_ignition_codegen is enabled. Otherwise, no handler would be dumped when using a snapshot. BUG=v8:4280 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Rebuild dispatch table when FLAG_trace_ignition_codegen is enabled. Otherwise, no handler would be dumped when using a snapshot. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Rebuild dispatch table when FLAG_trace_ignition_codegen is enabled. Otherwise, no handler would be dumped when using a snapshot. BUG=v8:4280 LOG=N Committed: https://crrev.com/0a4820d01ef4b109bed02cc0c8e003a8f296c2aa Cr-Commit-Position: refs/heads/master@{#34990} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/0a4820d01ef4b109bed02cc0c8e003a8f296c2aa Cr-Commit-Position: refs/heads/master@{#34990} |
