net: remove UsingTCPFastOpen() method from StreamSocket class

net: remove UsingTCPFastOpen() method from StreamSocket class

Commit c4699f6 ("net: add IsUsingTCPFastOpen() method to SequencedSocketData
test class") removed the usage of UsingTCPFastOpen(), so now it can be
removed safely.

BUG=488598
TEST=net_unittests
R=mmenke@chromium.org
TBR=dgozman@chromium.org,sergeyu@chromium.org

Committed: https://crrev.com/f933e0e731bf83f77540415e4ff719480323af80
Cr-Commit-Position: refs/heads/master@{#382604}

[tfarina, 2016-03-21 15:28:05]

Hey Matt, could you take a look at this and check if
everything I did this time is OK?

Thanks,

[mmenke, 2016-03-22 14:43:33]

LGTM, modulo one comment.

Thanks for doing this!

https://codereview.chromium.org/1821633003/diff/20001/net/socket/transport_cl...
File net/socket/transport_client_socket_pool_test_util.cc (right):

https://codereview.chromium.org/1821633003/diff/20001/net/socket/transport_cl...
net/socket/transport_client_socket_pool_test_util.cc:105: bool
use_tcp_fastopen_;
I believe this variable can be removed from all 3 test classes here.

[tfarina, 2016-03-22 16:30:35]

tfarina@chromium.org changed reviewers:
+ dgozman@chromium.org, sergeyu@chromium.org

[tfarina, 2016-03-22 16:30:36]

TBRing Sergey for content, jingle and remoting.
TBRing Dmitry for chrome.

https://codereview.chromium.org/1821633003/diff/20001/net/socket/transport_cl...
File net/socket/transport_client_socket_pool_test_util.cc (right):

https://codereview.chromium.org/1821633003/diff/20001/net/socket/transport_cl...
net/socket/transport_client_socket_pool_test_util.cc:105: bool
use_tcp_fastopen_;
On 2016/03/22 14:43:33, mmenke wrote:
> I believe this variable can be removed from all 3 test classes here.

Done.

[tfarina, 2016-03-22 16:30:59]

Description was changed from

==========
net: remove UsingTCPFastOpen() method from StreamSocket class

Commit c4699f6 ("net: add IsUsingTCPFastOpen() method to SequencedSocketData
test class") removed the usage of UsingTCPFastOpen(), so now it can be
removed safely.

BUG=488598
TEST=net_unittests
R=mmenke@chromium.org
==========

to

==========
net: remove UsingTCPFastOpen() method from StreamSocket class

Commit c4699f6 ("net: add IsUsingTCPFastOpen() method to SequencedSocketData
test class") removed the usage of UsingTCPFastOpen(), so now it can be
removed safely.

BUG=488598
TEST=net_unittests
R=mmenke@chromium.org
TBR=dgozman@chromium.org,sergeyu@chromium.org
==========

[tfarina, 2016-03-22 16:31:10]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2016-03-22 16:31:10]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1821633003/#ps40001
(title: "remove use_tcp_fastopen_ from
transport_client_socket_pool_test_util.cc")

[commit-bot: I haz the power, 2016-03-22 16:31:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821633003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821633003/40001

[commit-bot: I haz the power, 2016-03-22 17:45:49]

Description was changed from

==========
net: remove UsingTCPFastOpen() method from StreamSocket class

Commit c4699f6 ("net: add IsUsingTCPFastOpen() method to SequencedSocketData
test class") removed the usage of UsingTCPFastOpen(), so now it can be
removed safely.

BUG=488598
TEST=net_unittests
R=mmenke@chromium.org
TBR=dgozman@chromium.org,sergeyu@chromium.org
==========

to

==========
net: remove UsingTCPFastOpen() method from StreamSocket class

Commit c4699f6 ("net: add IsUsingTCPFastOpen() method to SequencedSocketData
test class") removed the usage of UsingTCPFastOpen(), so now it can be
removed safely.

BUG=488598
TEST=net_unittests
R=mmenke@chromium.org
TBR=dgozman@chromium.org,sergeyu@chromium.org
==========

[commit-bot: I haz the power, 2016-03-22 17:45:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-22 17:47:05]

Description was changed from

==========
net: remove UsingTCPFastOpen() method from StreamSocket class

Commit c4699f6 ("net: add IsUsingTCPFastOpen() method to SequencedSocketData
test class") removed the usage of UsingTCPFastOpen(), so now it can be
removed safely.

BUG=488598
TEST=net_unittests
R=mmenke@chromium.org
TBR=dgozman@chromium.org,sergeyu@chromium.org
==========

to

==========
net: remove UsingTCPFastOpen() method from StreamSocket class

Commit c4699f6 ("net: add IsUsingTCPFastOpen() method to SequencedSocketData
test class") removed the usage of UsingTCPFastOpen(), so now it can be
removed safely.

BUG=488598
TEST=net_unittests
R=mmenke@chromium.org
TBR=dgozman@chromium.org,sergeyu@chromium.org

Committed: https://crrev.com/f933e0e731bf83f77540415e4ff719480323af80
Cr-Commit-Position: refs/heads/master@{#382604}
==========

[commit-bot: I haz the power, 2016-03-22 17:47:06]

Patchset 3 (id:??) landed as
https://crrev.com/f933e0e731bf83f77540415e4ff719480323af80
Cr-Commit-Position: refs/heads/master@{#382604}