Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1821623003: Revert of Adding container class for chromoting client runtimes. (Closed)

Created:
4 years, 9 months ago by Lambros
Modified:
4 years, 9 months ago
Reviewers:
Sergey Ulanov, nicholss
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding container class for chromoting client runtimes. (patchset #23 id:440001 of https://codereview.chromium.org/1764503002/ ) Reason for revert: Broke Android client and tests - see bug 596240. Original issue's description: > Adding container class for chromoting client runtimes. > > R=lambroslambrou@chromium.org > > Committed: https://crrev.com/b34c0f6877af54e8bdd6052bf8934dd46a3b5899 > Cr-Commit-Position: refs/heads/master@{#380979} TBR=sergeyu@chromium.org,nicholss@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/2f93ea768bae27269c72b36752935f25b41a84d8 Cr-Commit-Position: refs/heads/master@{#382411}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -237 lines) Patch
M remoting/client/BUILD.gn View 1 1 chunk +0 lines, -5 lines 0 comments Download
D remoting/client/chromoting_client_runtime.h View 1 chunk +0 lines, -88 lines 0 comments Download
D remoting/client/chromoting_client_runtime.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D remoting/client/chromoting_client_runtime_unittest.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M remoting/client/jni/chromoting_jni_runtime.h View 1 3 chunks +11 lines, -10 lines 0 comments Download
M remoting/client/jni/chromoting_jni_runtime.cc View 1 11 chunks +36 lines, -35 lines 0 comments Download
M remoting/remoting_client.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M remoting/remoting_srcs.gypi View 1 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/remoting_test.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Lambros
Created Revert of Adding container class for chromoting client runtimes.
4 years, 9 months ago (2016-03-21 20:39:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821623003/1
4 years, 9 months ago (2016-03-21 20:40:06 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/175522) ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-21 20:42:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821623003/190001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821623003/190001
4 years, 9 months ago (2016-03-21 21:17:57 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:190001)
4 years, 9 months ago (2016-03-21 22:08:56 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 22:10:18 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f93ea768bae27269c72b36752935f25b41a84d8
Cr-Commit-Position: refs/heads/master@{#382411}

Powered by Google App Engine
This is Rietveld 408576698