Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1821573002: Enable dcheck_always_on on Win 10 FYI bot. (Closed)

Created:
4 years, 9 months ago by Will Harris
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Enable dcheck_always_on on Win 10 FYI bot. BUG=596344 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299429

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Win_10.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
Will Harris
PTAL
4 years, 9 months ago (2016-03-21 18:25:15 UTC) #4
Will Harris
+a real owner
4 years, 9 months ago (2016-03-21 21:19:57 UTC) #6
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-21 22:55:29 UTC) #7
M-A Ruel
sorry I somehow completely missed it. lgtm
4 years, 9 months ago (2016-03-22 00:10:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821573002/1
4 years, 9 months ago (2016-03-22 00:10:23 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/3255)
4 years, 9 months ago (2016-03-22 00:16:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821573002/20001
4 years, 9 months ago (2016-03-22 22:26:03 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 22:29:37 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299429

Powered by Google App Engine
This is Rietveld 408576698