Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1821563002: Fix chrome://site-engagement in incognito mode. (Closed)

Created:
4 years, 9 months ago by calamity
Modified:
4 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix chrome://site-engagement in incognito mode. BUG=596361 Committed: https://crrev.com/9d3afe9bb9f6e45a88d03529f14875616a673dc3 Cr-Commit-Position: refs/heads/master@{#382520}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/ui/webui/engagement/site_engagement_ui.cc View 2 chunks +6 lines, -2 lines 2 comments Download

Messages

Total messages: 11 (3 generated)
calamity
4 years, 9 months ago (2016-03-21 03:00:58 UTC) #2
Dan Beam
https://codereview.chromium.org/1821563002/diff/1/chrome/browser/ui/webui/engagement/site_engagement_ui.cc File chrome/browser/ui/webui/engagement/site_engagement_ui.cc (right): https://codereview.chromium.org/1821563002/diff/1/chrome/browser/ui/webui/engagement/site_engagement_ui.cc#newcode82 chrome/browser/ui/webui/engagement/site_engagement_ui.cc:82: return; you can't return from a ctor
4 years, 9 months ago (2016-03-21 17:01:12 UTC) #3
Dan Beam
can we do this at a higher level?
4 years, 9 months ago (2016-03-21 17:02:12 UTC) #4
calamity
Hmmmmmmmmmmm. So it seems like the only other place to put this logic is WebUIControllerFactory ...
4 years, 9 months ago (2016-03-22 04:32:42 UTC) #5
Dan Beam
ehhh, whatevs. lgtm if it compiles
4 years, 9 months ago (2016-03-22 04:38:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821563002/1
4 years, 9 months ago (2016-03-22 06:01:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 06:56:18 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 06:57:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d3afe9bb9f6e45a88d03529f14875616a673dc3
Cr-Commit-Position: refs/heads/master@{#382520}

Powered by Google App Engine
This is Rietveld 408576698