Fix chrome://site-engagement in incognito mode.

Fix chrome://site-engagement in incognito mode.

BUG=596361
Committed: https://crrev.com/9d3afe9bb9f6e45a88d03529f14875616a673dc3
Cr-Commit-Position: refs/heads/master@{#382520}

[calamity, 2016-03-21 03:00:54]

calamity@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-03-21 17:01:12]

https://codereview.chromium.org/1821563002/diff/1/chrome/browser/ui/webui/eng...
File chrome/browser/ui/webui/engagement/site_engagement_ui.cc (right):

https://codereview.chromium.org/1821563002/diff/1/chrome/browser/ui/webui/eng...
chrome/browser/ui/webui/engagement/site_engagement_ui.cc:82: return;
you can't return from a ctor

[Dan Beam, 2016-03-21 17:02:12]

can we do this at a higher level?

[calamity, 2016-03-22 04:32:42]

Hmmmmmmmmmmm. So it seems like the only other place to put this logic is
WebUIControllerFactory which feels a lot worse. 

I'm not exactly sure how, but the old history, extensions, settings (I guess any
uber-frame clients) redirected to the main window and opened the WebUI there.

In fact, MD downloads (not sure if it ever had it) and MD history don't have
this behavior =( Should we restore it there?

https://codereview.chromium.org/1821563002/diff/1/chrome/browser/ui/webui/eng...
File chrome/browser/ui/webui/engagement/site_engagement_ui.cc (right):

https://codereview.chromium.org/1821563002/diff/1/chrome/browser/ui/webui/eng...
chrome/browser/ui/webui/engagement/site_engagement_ui.cc:82: return;
On 2016/03/21 17:01:12, Dan Beam wrote:
> you can't return from a ctor

Seems to work.

http://stackoverflow.com/questions/5255777/what-if-i-write-return-statement-i...

Or is this one of those things that's verboten?

[Dan Beam, 2016-03-22 04:38:45]

ehhh, whatevs. lgtm if it compiles

[calamity, 2016-03-22 06:01:08]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-03-22 06:01:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821563002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821563002/1

[commit-bot: I haz the power, 2016-03-22 06:56:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-22 06:57:48]

Description was changed from

==========
Fix chrome://site-engagement in incognito mode.

BUG=596361
==========

to

==========
Fix chrome://site-engagement in incognito mode.

BUG=596361

Committed: https://crrev.com/9d3afe9bb9f6e45a88d03529f14875616a673dc3
Cr-Commit-Position: refs/heads/master@{#382520}
==========

[commit-bot: I haz the power, 2016-03-22 06:57:49]

Patchset 1 (id:??) landed as
https://crrev.com/9d3afe9bb9f6e45a88d03529f14875616a673dc3
Cr-Commit-Position: refs/heads/master@{#382520}