Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 1821543002: Issue 26044. Cache and use LibraryElementImpl.exportNamespace. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/task/dart.dart
diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart
index 063a7d9ab2793a40ac1a328dd4c0d97c936345d7..accc28ab856fcca000a86fecc8852105c540a7ed 100644
--- a/pkg/analyzer/lib/src/task/dart.dart
+++ b/pkg/analyzer/lib/src/task/dart.dart
@@ -2231,7 +2231,7 @@ class DartDelta extends Delta {
@override
DeltaResult validate(InternalAnalysisContext context, AnalysisTarget target,
- ResultDescriptor descriptor) {
+ ResultDescriptor descriptor, CacheState state, Object value) {
if (hasDirectiveChange) {
return DeltaResult.INVALIDATE;
}
@@ -2259,6 +2259,10 @@ class DartDelta extends Delta {
return DeltaResult.KEEP_CONTINUE;
}
if (BuildLibraryElementTask.DESCRIPTOR.results.contains(descriptor)) {
+ // Invalidate cached results.
+ if (value is LibraryElementImpl) {
+ value.exportNamespace = null;
+ }
return DeltaResult.KEEP_CONTINUE;
}
return DeltaResult.INVALIDATE;

Powered by Google App Engine
This is Rietveld 408576698