guard rasterizer and drawlooper setters

guard rasterizer and drawlooper setters

Need to land https://codereview.chromium.org/1823513002/ first

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1821533002

Committed: https://skia.googlesource.com/skia/+/7b380d0d0e91ae6967c52bfa14853a77b9551de4

[reed1, 2016-03-20 20:23:53]

Description was changed from

==========
guard rasterizer and drawlooper setters

BUG=skia:
==========

to

==========
guard rasterizer and drawlooper setters

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-03-20 20:35:42]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-20 20:35:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821533002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821533002/20001

[reed1, 2016-03-20 20:37:21]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-03-20 21:02:44]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-20 21:02:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821533002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821533002/40001

[reed1, 2016-03-20 21:03:39]

reed@google.com changed reviewers:
+ fmalita@chromium.org

[reed1, 2016-03-20 21:04:12]

Description was changed from

==========
guard rasterizer and drawlooper setters

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
guard rasterizer and drawlooper setters

Need to land https://codereview.chromium.org/1823513002/ first

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-03-20 21:08:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-20 21:08:42]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)

[reed1, 2016-03-20 21:12:33]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-20 21:12:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821533002/60001

[commit-bot: I haz the power, 2016-03-20 21:21:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-20 21:22:03]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-03-21 13:53:44]

lgtm

https://codereview.chromium.org/1821533002/diff/60001/gm/circles.cpp
File gm/circles.cpp (right):

https://codereview.chromium.org/1821533002/diff/60001/gm/circles.cpp#newcode86
gm/circles.cpp:86: p.setLooper(shadowLooper);
nit: looks like we can std::move here.

https://codereview.chromium.org/1821533002/diff/60001/gm/rects.cpp
File gm/rects.cpp (right):

https://codereview.chromium.org/1821533002/diff/60001/gm/rects.cpp#newcode101
gm/rects.cpp:101: p.setLooper(shadowLooper);
nit: ditto

https://codereview.chromium.org/1821533002/diff/60001/tools/debugger/SkDrawCo...
File tools/debugger/SkDrawCommand.cpp (right):

https://codereview.chromium.org/1821533002/diff/60001/tools/debugger/SkDrawCo...
tools/debugger/SkDrawCommand.cpp:1160: target->setLooper(looper);
nit: ditto

[reed1, 2016-03-21 17:15:23]

https://codereview.chromium.org/1821533002/diff/60001/gm/circles.cpp
File gm/circles.cpp (right):

https://codereview.chromium.org/1821533002/diff/60001/gm/circles.cpp#newcode86
gm/circles.cpp:86: p.setLooper(shadowLooper);
On 2016/03/21 13:53:43, f(malita) wrote:
> nit: looks like we can std::move here.

Done.

https://codereview.chromium.org/1821533002/diff/60001/gm/rects.cpp
File gm/rects.cpp (right):

https://codereview.chromium.org/1821533002/diff/60001/gm/rects.cpp#newcode101
gm/rects.cpp:101: p.setLooper(shadowLooper);
On 2016/03/21 13:53:43, f(malita) wrote:
> nit: ditto

Done.

https://codereview.chromium.org/1821533002/diff/60001/tools/debugger/SkDrawCo...
File tools/debugger/SkDrawCommand.cpp (right):

https://codereview.chromium.org/1821533002/diff/60001/tools/debugger/SkDrawCo...
tools/debugger/SkDrawCommand.cpp:1160: target->setLooper(looper);
On 2016/03/21 13:53:44, f(malita) wrote:
> nit: ditto

Done.

[reed1, 2016-03-21 20:10:07]

The CQ bit was checked by reed@google.com

[reed1, 2016-03-21 20:10:07]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1821533002/#ps100001
(title: "guard google3")

[commit-bot: I haz the power, 2016-03-21 20:10:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821533002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821533002/100001

[commit-bot: I haz the power, 2016-03-21 20:25:19]

Description was changed from

==========
guard rasterizer and drawlooper setters

Need to land https://codereview.chromium.org/1823513002/ first

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
guard rasterizer and drawlooper setters

Need to land https://codereview.chromium.org/1823513002/ first

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7b380d0d0e91ae6967c52bfa14853a77b9551de4
==========

[commit-bot: I haz the power, 2016-03-21 20:25:20]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/7b380d0d0e91ae6967c52bfa14853a77b9551de4