Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: fpdfsdk/javascript/JS_EventHandler.cpp

Issue 1821423002: Re-enable MSVC warning 4702 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: address comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "fpdfsdk/javascript/JS_EventHandler.h" 7 #include "fpdfsdk/javascript/JS_EventHandler.h"
8 8
9 #include "fpdfsdk/include/javascript/IJavaScript.h" 9 #include "fpdfsdk/include/javascript/IJavaScript.h"
10 #include "fpdfsdk/javascript/Document.h" 10 #include "fpdfsdk/javascript/Document.h"
(...skipping 496 matching lines...) Expand 10 before | Expand all | Expand 10 after
507 return L"Close"; 507 return L"Close";
508 case JET_SCREEN_INVIEW: 508 case JET_SCREEN_INVIEW:
509 case JET_PAGE_INVIEW: 509 case JET_PAGE_INVIEW:
510 return L"InView"; 510 return L"InView";
511 case JET_PAGE_OUTVIEW: 511 case JET_PAGE_OUTVIEW:
512 case JET_SCREEN_OUTVIEW: 512 case JET_SCREEN_OUTVIEW:
513 return L"OutView"; 513 return L"OutView";
514 default: 514 default:
515 return L""; 515 return L"";
516 } 516 }
517
518 return L"";
519 } 517 }
520 518
521 const FX_WCHAR* CJS_EventHandler::Type() { 519 const FX_WCHAR* CJS_EventHandler::Type() {
522 switch (m_eEventType) { 520 switch (m_eEventType) {
523 case JET_APP_INIT: 521 case JET_APP_INIT:
524 return L"App"; 522 return L"App";
525 case JET_BATCH_EXEC: 523 case JET_BATCH_EXEC:
526 return L"Batch"; 524 return L"Batch";
527 case JET_BOOKMARK_MOUSEUP: 525 case JET_BOOKMARK_MOUSEUP:
528 return L"BookMark"; 526 return L"BookMark";
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
564 case JET_MENU_EXEC: 562 case JET_MENU_EXEC:
565 return L"Menu"; 563 return L"Menu";
566 case JET_PAGE_OPEN: 564 case JET_PAGE_OPEN:
567 case JET_PAGE_CLOSE: 565 case JET_PAGE_CLOSE:
568 case JET_PAGE_INVIEW: 566 case JET_PAGE_INVIEW:
569 case JET_PAGE_OUTVIEW: 567 case JET_PAGE_OUTVIEW:
570 return L"Page"; 568 return L"Page";
571 default: 569 default:
572 return L""; 570 return L"";
573 } 571 }
574
575 return L"";
576 } 572 }
577 573
578 FX_BOOL& CJS_EventHandler::Rc() { 574 FX_BOOL& CJS_EventHandler::Rc() {
579 if (m_pbRc) { 575 if (m_pbRc) {
580 return *m_pbRc; 576 return *m_pbRc;
581 } 577 }
582 return m_bRcDu; 578 return m_bRcDu;
583 } 579 }
584 580
585 int& CJS_EventHandler::SelEnd() { 581 int& CJS_EventHandler::SelEnd() {
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
650 return *m_pValue; 646 return *m_pValue;
651 } 647 }
652 648
653 FX_BOOL CJS_EventHandler::WillCommit() { 649 FX_BOOL CJS_EventHandler::WillCommit() {
654 return m_bWillCommit; 650 return m_bWillCommit;
655 } 651 }
656 652
657 CFX_WideString CJS_EventHandler::TargetName() { 653 CFX_WideString CJS_EventHandler::TargetName() {
658 return m_strTargetName; 654 return m_strTargetName;
659 } 655 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698