Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1821413002: Fix parsing of double dot operators for FormCalc (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix parsing of double dot operators for FormCalc Patch by cherycherian. patch from issue 1810153003 at patchset 1 (http://crrev.com/1810153003#ps1) FormCalc expressions containing double-dot operators in SOM expressions were failing since XFA_ResolveNodes_AnyChild was always stripping the leading character. Roll testing/corpus to d671154 to pick up the test. BUG=pdfium:434 TBR=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/3523c1f23e4c48850fcba5b1cb1bd8f311407e00

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Suppressions for non-xfa cases. #

Patch Set 4 : Windows xfa diff'd. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M AUTHORS View 2 chunks +2 lines, -0 lines 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M testing/SUPPRESSIONS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_resolveprocessor.cpp View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
Tom Sepez
Dan, TBR as I've already LGTM'd the original.
4 years, 9 months ago (2016-03-22 21:38:45 UTC) #2
Tom Sepez
4 years, 9 months ago (2016-03-22 23:05:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
3523c1f23e4c48850fcba5b1cb1bd8f311407e00 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698