Issue 18214003: Change static_cast<SVGImageElement*> with toSVGImageElement.

Issue 18214003: Change static_cast<SVGImageElement*> with toSVGImageElement. (Closed)

Created:
7 years, 5 months ago by gyuyoung-inactive

Modified:
7 years, 5 months ago

Reviewers:
tkent

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Change static_cast<SVGImageElement*> with toSVGImageElement. As a step to change static_cast with toXXX, static_cast<SVGImageElement*> can be changed with toSVGImageElement(). BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153557

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : Fix build break #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
M	Source/core/rendering/svg/RenderSVGImage.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGImageElement.h	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGImageLoader.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

tkent

https://codereview.chromium.org/18214003/diff/1/Source/core/svg/SVGImageElement.h File Source/core/svg/SVGImageElement.h (right): https://codereview.chromium.org/18214003/diff/1/Source/core/svg/SVGImageElement.h#newcode80 Source/core/svg/SVGImageElement.h:80: ASSERT_WITH_SECURITY_IMPLICATION(!node || (node->isSVGImageElement() && node->isSVGElement())); Do we have Node::isSVGImageElement?

7 years, 5 months ago (2013-07-04 02:07:31 UTC) #2

gyuyoung-inactive

On 2013/07/04 02:07:31, tkent wrote: > https://codereview.chromium.org/18214003/diff/1/Source/core/svg/SVGImageElement.h > File Source/core/svg/SVGImageElement.h (right): > > https://codereview.chromium.org/18214003/diff/1/Source/core/svg/SVGImageElement.h#newcode80 > ...

7 years, 5 months ago (2013-07-04 02:37:26 UTC) #3

tkent

lgtm On 2013/07/04 02:37:26, gyuyoung wrote: > Oops, I confused isSVGImage(). My bad. I change ...

7 years, 5 months ago (2013-07-04 02:38:57 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/18214003/6001

7 years, 5 months ago (2013-07-04 02:39:52 UTC) #5

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 5 months ago (2013-07-04 03:00:55 UTC) #6

gyuyoung-inactive

On 2013/07/04 03:00:55, I haz the power (commit-bot) wrote: > Sorry for I got bad ...

7 years, 5 months ago (2013-07-04 03:37:47 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/18214003/20001

7 years, 5 months ago (2013-07-04 05:28:19 UTC) #8

Message was sent while issue was closed.

Change committed as 153557

Expand Messages | Collapse Messages