Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: tests/SpecialImageTest.cpp

Issue 1821303002: Remove SkPixmap::release (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkAutoPixmapStorage.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/SpecialImageTest.cpp
diff --git a/tests/SpecialImageTest.cpp b/tests/SpecialImageTest.cpp
index 432adc832735ff8eb1246bf8c104d508f94a063e..bd07115dbfdca82797d7f58b5af05b3f09ec7f7a 100644
--- a/tests/SpecialImageTest.cpp
+++ b/tests/SpecialImageTest.cpp
@@ -183,23 +183,10 @@ DEF_TEST(SpecialImage_Pixmap, reporter) {
pixmap.erase(SK_ColorRED, subset);
{
- // The SkAutoPixmapStorage keeps hold of the memory
sk_sp<SkSpecialImage> img(SkSpecialImage::MakeFromPixmap(nullptr, subset, pixmap,
nullptr, nullptr));
test_image(img, reporter, true, false, kPad, kFullSize);
}
-
- {
- // The image takes ownership of the memory
- sk_sp<SkSpecialImage> img(SkSpecialImage::MakeFromPixmap(
- nullptr, subset, pixmap,
- [] (void* addr, void*) -> void {
- sk_free(addr);
- },
- nullptr));
- pixmap.release();
- test_image(img, reporter, true, false, kPad, kFullSize);
- }
}
« no previous file with comments | « src/core/SkAutoPixmapStorage.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698