src/build/common.gypi - Issue 1821293002: Replace libdisasm with capstone

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/build/common.gypi

Issue 1821293002: Replace libdisasm with capstone Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/build/common.gypi

diff --git a/src/build/common.gypi b/src/build/common.gypi

index b9466a325ad5a37e7e6da7782d2788e23b76ac05..572064d369c2956225450c56d5fc9ead0f5f984a 100644

--- a/src/build/common.gypi

+++ b/src/build/common.gypi

@@ -554,7 +554,7 @@

'cflags': [

- '<(werror)', # See note above about the werror variable.

+ '<(werror)', # See note above about the werror variable

vapier 2016/06/24 20:09:07 unrelated/undesirable change ?

'-pthread',

'-fno-exceptions',

'-Wall',

@@ -570,6 +570,7 @@

'-fvisibility=hidden',

'cflags_cc': [

+ '-std=c++11',

vapier 2016/06/24 20:09:07 this should prob be deployed in a dedicated CL, as

'-frtti',

'-fno-threadsafe-statics',

# Make inline functions have hidden visiblity by default.

« no previous file with comments | « Makefile.in ('k') | src/config.h.in » ('j') | src/third_party/capstone.gyp » ('J')