src/third_party/libdisasm/TODO - Issue 1821293002: Replace libdisasm with capstone

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/third_party/libdisasm/TODO

Issue 1821293002: Replace libdisasm with capstone Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 x86_format.c

2 ------------

3 intel: jmpf -> jmp, callf -> call

4 att: jmpf -> ljmp, callf -> lcall

5

6 opcode table

7 ------------

8 finish typing instructions

9 fix flag clear/set/toggle types

10

11 ix64 stuff

12 ----------

13 document output file formats in web page

14 features doc: register aliases, implicit operands, stack mods,

15 ring0 flags, eflags, cpu model/isa

16

17 ia32_handle_* implementation

18

19 fix operand 0F C2

20 CMPPS

21

22 * sysenter, sysexit as CALL types -- preceded by MSR writes

23 * SYSENTER/SYSEXIT stack : overwrites SS, ESP

24 * stos, cmps, scas, movs, ins, outs, lods -> OP_PTR

25 * OP_SIZE in implicit operands

26 * use OP_SIZE to choose reg sizes!

27

28 DONE?? :

29 implicit operands: provide action ?

30 e.g. add/inc for stach, write, etc

31 replace table numbers in opcodes.dat with

32 #defines for table names

33

34 replace 0 with INSN_INVALID [or maybe FF for imnvalid and 00 for Not Applicab le */

35 no wait that is only for prefix tables -- n/p

36

37 if ( prefx) only use if insn != invalid

38

39 these should cover all the wacky disasm exceptions

40

41 for the rep one we can chet, match only a 0x90

42

43 todo: privilege \| ring

OLD	NEW