Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1821283002: Fix background compilation: handle compilation abort during parsing. (Closed)

Created:
4 years, 9 months ago by srdjan
Modified:
4 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix background compilation: handle compilation abort during parsing. Abort background compilation if finalization is necessary. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/f360e1a2b667db001416f4a0aa0063d062d3ab4d

Patch Set 1 #

Patch Set 2 : Abort background compilation when finalization is necessary #

Patch Set 3 : t #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M runtime/vm/compiler.cc View 1 2 chunks +14 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
srdjan
4 years, 9 months ago (2016-03-22 18:13:18 UTC) #3
rmacnak
lgtm
4 years, 9 months ago (2016-03-22 19:56:57 UTC) #4
srdjan
4 years, 9 months ago (2016-03-22 20:43:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f360e1a2b667db001416f4a0aa0063d062d3ab4d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698