Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1821203002: Merge branch 'master' of github.com:dart-lang/sdk into update-status-file (Closed)

Created:
4 years, 9 months ago by zra
Modified:
4 years, 9 months ago
Reviewers:
Bill Hesse, Ivan Posva
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/standalone/standalone.status View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zra
TBR
4 years, 9 months ago (2016-03-22 14:57:22 UTC) #3
zra
Committed patchset #1 (id:1) manually as b81aa55a0cb77bef03157e9d5fcc0e78a4e3fcfc (presubmit successful).
4 years, 9 months ago (2016-03-22 14:57:55 UTC) #5
Ivan Posva
LGTM -ip
4 years, 9 months ago (2016-03-22 14:59:17 UTC) #6
Bill Hesse
4 years, 9 months ago (2016-03-22 16:00:24 UTC) #8
Message was sent while issue was closed. 
We should put comments on the same line as a status update:
  : Skip # Issue 26057

All lines in a status file should have an issue associated with them, and
comments on a line are not enough, there needs to be an issue. Admittedly, we
haven't made a linter yet to enforce this, but we plan to.

Powered by Google App Engine
This is Rietveld 408576698