Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1821183002: [interpreter] Disable mjsunit/ignition/elided-instruction (Closed)

Created:
4 years, 9 months ago by oth
Modified:
4 years, 9 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Disable mjsunit/ignition/elided-instruction BUG=v8:4680 LOG=N Committed: https://crrev.com/9383d14b9f496a02e18bdf8e4ee6226e86b51af9 Cr-Commit-Position: refs/heads/master@{#34991}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Skip more. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
oth
PTAL
4 years, 9 months ago (2016-03-22 13:52:34 UTC) #2
rmcilroy
LGTM with comments. https://codereview.chromium.org/1821183002/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/1821183002/diff/1/test/mjsunit/mjsunit.status#newcode818 test/mjsunit/mjsunit.status:818: 'ignition/elided-instruction': [SKIP], it looks like there ...
4 years, 9 months ago (2016-03-22 14:02:42 UTC) #3
oth
Thanks! https://codereview.chromium.org/1821183002/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/1821183002/diff/1/test/mjsunit/mjsunit.status#newcode818 test/mjsunit/mjsunit.status:818: 'ignition/elided-instruction': [SKIP], On 2016/03/22 14:02:42, rmcilroy wrote: > ...
4 years, 9 months ago (2016-03-22 14:16:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821183002/20001
4 years, 9 months ago (2016-03-22 14:16:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-22 14:39:41 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 14:40:55 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9383d14b9f496a02e18bdf8e4ee6226e86b51af9
Cr-Commit-Position: refs/heads/master@{#34991}

Powered by Google App Engine
This is Rietveld 408576698