media: Use PassInterface() in mojo media classes

media: Use PassInterface() in mojo media classes

This is the preferred way to bind an InterfacePtr on one thread and then
use it on another thread.

BUG=596925
TEST=Manually tested.

Committed: https://crrev.com/ac9ee0c8ef4c20df609f7d34c068d9a97363160e
Cr-Commit-Position: refs/heads/master@{#382708}

[xhwang, 2016-03-22 18:57:46]

xhwang@chromium.org changed reviewers:
+ yzshen@chromium.org

[xhwang, 2016-03-22 18:57:47]

PTAL and help me make sure I am using it correctly :)

[xhwang, 2016-03-22 18:57:55]

Description was changed from

==========
media: Use PassInterface() in mojo media classes.

This is the preferred way to bind an InterfacePtr on one thread and then
use it on another thread.

BUG=596925
TEST=Manually tested.
==========

to

==========
media: Use PassInterface() in mojo media classes

This is the preferred way to bind an InterfacePtr on one thread and then
use it on another thread.

BUG=596925
TEST=Manually tested.
==========

[yzshen1, 2016-03-22 19:15:04]

Thanks LGTM!

https://chromiumcodereview.appspot.com/1821153004/diff/20001/media/mojo/servi...
File media/mojo/services/mojo_audio_decoder.h (right):

https://chromiumcodereview.appspot.com/1821153004/diff/20001/media/mojo/servi...
media/mojo/services/mojo_audio_decoder.h:71:
mojo::InterfacePtrInfo<interfaces::AudioDecoder> remote_decoder_info_;
optional: you could use interfaces::AudioDecoderPtrInfo as the type name, too.

https://chromiumcodereview.appspot.com/1821153004/diff/20001/media/mojo/servi...
File media/mojo/services/mojo_renderer_impl.h (right):

https://chromiumcodereview.appspot.com/1821153004/diff/20001/media/mojo/servi...
media/mojo/services/mojo_renderer_impl.h:84:
mojo::InterfacePtrInfo<interfaces::Renderer> remote_renderer_info_;
optional: interfaces::RendererPtrInfo

[xhwang, 2016-03-22 19:43:46]

comments addressed

[xhwang, 2016-03-22 19:45:26]

Thanks for the review!

https://chromiumcodereview.appspot.com/1821153004/diff/20001/media/mojo/servi...
File media/mojo/services/mojo_audio_decoder.h (right):

https://chromiumcodereview.appspot.com/1821153004/diff/20001/media/mojo/servi...
media/mojo/services/mojo_audio_decoder.h:71:
mojo::InterfacePtrInfo<interfaces::AudioDecoder> remote_decoder_info_;
On 2016/03/22 19:15:04, yzshen1 wrote:
> optional: you could use interfaces::AudioDecoderPtrInfo as the type name, too.

Done.

https://chromiumcodereview.appspot.com/1821153004/diff/20001/media/mojo/servi...
File media/mojo/services/mojo_renderer_impl.h (right):

https://chromiumcodereview.appspot.com/1821153004/diff/20001/media/mojo/servi...
media/mojo/services/mojo_renderer_impl.h:84:
mojo::InterfacePtrInfo<interfaces::Renderer> remote_renderer_info_;
On 2016/03/22 19:15:04, yzshen1 wrote:
> optional: interfaces::RendererPtrInfo

Done.

[xhwang, 2016-03-22 19:45:58]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2016-03-22 19:45:59]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1821153004/#ps40001
(title: "comments addressed")

[commit-bot: I haz the power, 2016-03-22 19:46:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821153004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821153004/40001

[commit-bot: I haz the power, 2016-03-22 22:18:09]

Description was changed from

==========
media: Use PassInterface() in mojo media classes

This is the preferred way to bind an InterfacePtr on one thread and then
use it on another thread.

BUG=596925
TEST=Manually tested.
==========

to

==========
media: Use PassInterface() in mojo media classes

This is the preferred way to bind an InterfacePtr on one thread and then
use it on another thread.

BUG=596925
TEST=Manually tested.
==========

[commit-bot: I haz the power, 2016-03-22 22:18:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-22 22:19:34]

Description was changed from

==========
media: Use PassInterface() in mojo media classes

This is the preferred way to bind an InterfacePtr on one thread and then
use it on another thread.

BUG=596925
TEST=Manually tested.
==========

to

==========
media: Use PassInterface() in mojo media classes

This is the preferred way to bind an InterfacePtr on one thread and then
use it on another thread.

BUG=596925
TEST=Manually tested.

Committed: https://crrev.com/ac9ee0c8ef4c20df609f7d34c068d9a97363160e
Cr-Commit-Position: refs/heads/master@{#382708}
==========

[commit-bot: I haz the power, 2016-03-22 22:19:35]

Patchset 3 (id:??) landed as
https://crrev.com/ac9ee0c8ef4c20df609f7d34c068d9a97363160e
Cr-Commit-Position: refs/heads/master@{#382708}