remoting/protocol/webrtc_video_capturer_adapter.h - Issue 1821153003: Avoid using MakeExclusive, which is going to be deleted in webrtc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/webrtc_video_capturer_adapter.h

Issue 1821153003: Avoid using MakeExclusive, which is going to be deleted in webrtc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed to compile with latest webrtc. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/protocol/webrtc_video_capturer_adapter.h

diff --git a/remoting/protocol/webrtc_video_capturer_adapter.h b/remoting/protocol/webrtc_video_capturer_adapter.h

index e13c06b6684380265ac9f018b4a3ec2f147aa61f..c3df48a1dcb303485a12ae31fc1a9c0c384b1055 100644

--- a/remoting/protocol/webrtc_video_capturer_adapter.h

+++ b/remoting/protocol/webrtc_video_capturer_adapter.h

@@ -83,7 +83,7 @@ class WebrtcVideoCapturerAdapter : public cricket::VideoCapturer,

// Video frame is kept between captures to avoid YUV conversion for static

// parts of the screen.

- scoped_ptr<cricket::VideoFrame> yuv_frame_;

+ rtc::scoped_refptr<webrtc::I420Buffer> yuv_frame_;

perkj_chrome 2016/03/30 14:58:26 nit: This should use Chromes scoped_refptr - not R

bool capture_pending_ = false;

bool paused_ = false;

@@ -97,4 +97,3 @@ class WebrtcVideoCapturerAdapter : public cricket::VideoCapturer,

} // namespace remoting

#endif // REMOTING_PROTOCOL_WEBRTC_VIDEO_CAPTURER_ADAPTER_H_

« no previous file with comments | « no previous file | remoting/protocol/webrtc_video_capturer_adapter.cc » ('j') | no next file with comments »