Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1821133002: [turbofan] Add more sanity checks to representation inference. (Closed)

Created:
4 years, 9 months ago by Jarin
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add more sanity checks to representation inference. The CL also add guard nodes to places where we assume that certain values are numbers. Committed: https://crrev.com/e1bd9af1733b03175f62872cca3697bd46a23c42 Cr-Commit-Position: refs/heads/master@{#34977}

Patch Set 1 #

Patch Set 2 : Type match #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -70 lines) Patch
M src/compiler/js-intrinsic-lowering.cc View 5 chunks +18 lines, -1 line 0 comments Download
M src/compiler/representation-change.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/representation-change.cc View 5 chunks +48 lines, -50 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 3 chunks +9 lines, -15 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 2 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
4 years, 9 months ago (2016-03-22 06:30:49 UTC) #2
Benedikt Meurer
lgtm
4 years, 9 months ago (2016-03-22 06:38:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821133002/20001
4 years, 9 months ago (2016-03-22 06:41:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-22 06:50:24 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 06:50:59 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1bd9af1733b03175f62872cca3697bd46a23c42
Cr-Commit-Position: refs/heads/master@{#34977}

Powered by Google App Engine
This is Rietveld 408576698