Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 182113004: DevTools: Get rid of Element.prototype.enableStyleClass (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
Reviewers:
eustas, apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Get rid of Element.prototype.enableStyleClass R=pfeldman, apavlov, eustas NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168442

Patch Set 1 #

Patch Set 2 : Rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -67 lines) Patch
M Source/devtools/front_end/CPUProfileView.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/CanvasProfileView.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/CodeMirrorTextEditor.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/ConsoleView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/DOMExtension.js View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/devtools/front_end/DataGrid.js View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/Drawer.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/FilterBar.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/FilteredItemSelectionDialog.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/InplaceFormatterEditorAction.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/LayerTree.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/Layers3DView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/NetworkPanel.js View 1 7 chunks +9 lines, -9 lines 0 comments Download
M Source/devtools/front_end/OverridesView.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/PlatformFontsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ScriptFormatterEditorAction.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/SearchableView.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/SourcesPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/SplitView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/StatusBarButton.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/StylesSidebarPane.js View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/ThreadsToolbar.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/TimelinePanel.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/TimelineView.js View 1 4 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/UISourceCodeFrame.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
vsevik
PTAL
6 years, 9 months ago (2014-03-04 17:33:52 UTC) #1
eustas
lgtm
6 years, 9 months ago (2014-03-05 07:28:20 UTC) #2
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 9 months ago (2014-03-05 07:28:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/182113004/20001
6 years, 9 months ago (2014-03-05 07:29:01 UTC) #4
commit-bot: I haz the power
Change committed as 168442
6 years, 9 months ago (2014-03-05 07:30:39 UTC) #5
arv (Not doing code reviews)
On 2014/03/05 07:30:39, I haz the power (commit-bot) wrote: > Change committed as 168442 This ...
6 years, 9 months ago (2014-03-05 15:31:29 UTC) #6
arv (Not doing code reviews)
6 years, 9 months ago (2014-03-05 15:31:56 UTC) #7
Message was sent while issue was closed.
On 2014/03/05 15:31:29, arv wrote:
> On 2014/03/05 07:30:39, I haz the power (commit-bot) wrote:
> > Change committed as 168442
> 
> This never landed... git cl push instead of git cl dcommit...

Sorry... wrong window.

Powered by Google App Engine
This is Rietveld 408576698