Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1821113002: X87: [es6] Faster implementation of OrdinaryHasInstance. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [es6] Faster implementation of OrdinaryHasInstance. port b6419fa2298de8e292c6bed0bd20de5c96f7da12 (r34959) original commit message: Now implemented as a builtin that delegates to the InstanceOfStub. That stub was parameterized to fallback to either Runtime_InstanceOf or to Runtime_OrdinaryHasInstance depending on the --harmony-instanceof flag. Once the feature stabilizes and the flag is no longer needed, we can get rid of this parameterization again. BUG= Committed: https://crrev.com/4c0ad049193699e5a670571e2502e0a213fee10e Cr-Commit-Position: refs/heads/master@{#34975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +22 lines, -1 line 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-22 05:45:44 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-22 06:04:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821113002/1
4 years, 9 months ago (2016-03-22 06:05:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 06:24:27 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 06:25:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c0ad049193699e5a670571e2502e0a213fee10e
Cr-Commit-Position: refs/heads/master@{#34975}

Powered by Google App Engine
This is Rietveld 408576698