tools/android/SkAndroidSDKCanvas.cpp - Issue 1821103004: Revert of Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/SkAndroidSDKCanvas.cpp

Issue 1821103004: Revert of Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/android/SkAndroidSDKCanvas.cpp

diff --git a/tools/android/SkAndroidSDKCanvas.cpp b/tools/android/SkAndroidSDKCanvas.cpp

index d7a76ca215f54889460b4a68edb29fc443752889..35b1581fdab2df6175120e9cc9991cab1f19336e 100644

--- a/tools/android/SkAndroidSDKCanvas.cpp

+++ b/tools/android/SkAndroidSDKCanvas.cpp

@@ -69,7 +69,7 @@

bool isMode = cf->asColorMode(&color, &mode);

if (isMode && mode > SkXfermode::kLighten_Mode) {

paint->setColorFilter(

- SkColorFilter::MakeModeFilter(color, SkXfermode::kSrcOver_Mode));

+ SkColorFilter::CreateModeFilter(color, SkXfermode::kSrcOver_Mode));

} else if (!isMode && !cf->asColorMatrix(srcColorMatrix)) {

paint->setColorFilter(nullptr);

}

« no previous file with comments | « tests/SkColor4fTest.cpp ('k') | tools/debugger/SkDrawCommand.cpp » ('j') | no next file with comments »