gm/blurroundrect.cpp - Issue 1821103004: Revert of Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/blurroundrect.cpp

Issue 1821103004: Revert of Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/blurroundrect.cpp

diff --git a/gm/blurroundrect.cpp b/gm/blurroundrect.cpp

index 9135ba099f54733ac5f44f49420f4ad9e095ee76..fe4a93994628d8401562f9a7321cde86add4017a 100644

--- a/gm/blurroundrect.cpp

+++ b/gm/blurroundrect.cpp

@@ -60,9 +60,10 @@

SkBlurMask::ConvertRadiusToSigma(SK_ScalarHalf),

SkBlurMaskFilter::kHighQuality_BlurFlag);

paint->setMaskFilter(maskFilter)->unref();

- paint->setColorFilter(SkColorFilter::MakeModeFilter(

+ SkColorFilter* colorFilter = SkColorFilter::CreateModeFilter(

sk_tool_utils::color_to_565(SK_ColorLTGRAY),

- SkXfermode::kSrcIn_Mode));

+ SkXfermode::kSrcIn_Mode);

+ paint->setColorFilter(colorFilter)->unref();

paint->setColor(sk_tool_utils::color_to_565(SK_ColorGRAY));

}

{

« no previous file with comments | « gm/blurredclippedcircle.cpp ('k') | gm/color4f.cpp » ('j') | no next file with comments »