src/effects/SkLayerDrawLooper.cpp - Issue 1821103004: Revert of Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkLayerDrawLooper.cpp

Issue 1821103004: Revert of Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/SkLayerDrawLooper.cpp

diff --git a/src/effects/SkLayerDrawLooper.cpp b/src/effects/SkLayerDrawLooper.cpp

index 8510767801c174a401cf28b0a3fb31b157ee1bc6..ae31482ae7bdf5ff3747680b902286a9447660a5 100644

--- a/src/effects/SkLayerDrawLooper.cpp

+++ b/src/effects/SkLayerDrawLooper.cpp

@@ -102,7 +102,7 @@

dst->setShader(src.getShader());

}

if (bits & kColorFilter_Bit) {

- dst->setColorFilter(sk_ref_sp(src.getColorFilter()));

+ dst->setColorFilter(src.getColorFilter());

}

if (bits & kXfermode_Bit) {

dst->setXfermode(src.getXfermode());

« no previous file with comments | « src/effects/SkDropShadowImageFilter.cpp ('k') | src/effects/SkLumaColorFilter.cpp » ('j') | no next file with comments »