include/effects/SkLumaColorFilter.h - Issue 1821103004: Revert of Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/effects/SkLumaColorFilter.h

Issue 1821103004: Revert of Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/effects/SkLumaColorFilter.h

diff --git a/include/effects/SkLumaColorFilter.h b/include/effects/SkLumaColorFilter.h

index 3a68607b1977dee04471ef958c3a71a5153c1c1c..8dd519af4a77fe5ea142e9d8a15c4bfbc4c4a2e5 100644

--- a/include/effects/SkLumaColorFilter.h

+++ b/include/effects/SkLumaColorFilter.h

@@ -23,11 +23,7 @@

class SK_API SkLumaColorFilter : public SkColorFilter {

public:

- static sk_sp<SkColorFilter> Make();

-#ifdef SK_SUPPORT_LEGACY_COLORFILTER_PTR

- static SkColorFilter* Create() { return Make().release(); }

-#endif

+ static SkColorFilter* Create();

void filterSpan(const SkPMColor src[], int count, SkPMColor[]) const override;

« no previous file with comments | « include/effects/SkColorMatrixFilter.h ('k') | include/effects/SkTableColorFilter.h » ('j') | no next file with comments »