gm/megalooper.cpp - Issue 1821103004: Revert of Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/megalooper.cpp

Issue 1821103004: Revert of Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/megalooper.cpp

diff --git a/gm/megalooper.cpp b/gm/megalooper.cpp

index 6f5640272fc068de9f84b80341c69c3c8c77b7c3..5fe9af298b0d751eb7966b7ec9f3067ab12490a5 100644

--- a/gm/megalooper.cpp

+++ b/gm/megalooper.cpp

@@ -175,7 +175,8 @@

paint->setMaskFilter(this->createBlur())->unref();

- paint->setColorFilter(SkColorFilter::MakeModeFilter(color, SkXfermode::kSrcIn_Mode));

+ SkColorFilter* cf = SkColorFilter::CreateModeFilter(color, SkXfermode::kSrcIn_Mode);

+ paint->setColorFilter(cf)->unref();

return looperBuilder.detach();

}

@@ -221,8 +222,8 @@

paint->setMaskFilter(this->createBlur())->unref();

- paint->setColorFilter(SkColorFilter::MakeModeFilter(gColors[i],

- SkXfermode::kSrcIn_Mode));

+ SkColorFilter* cf = SkColorFilter::CreateModeFilter(gColors[i], SkXfermode::kSrcIn_Mode);

+ paint->setColorFilter(cf)->unref();

}

return looperBuilder.detach();

« no previous file with comments | « gm/lumafilter.cpp ('k') | gm/modecolorfilters.cpp » ('j') | no next file with comments »