third_party/WebKit/LayoutTests/plugins/embed-attributes-setting.html - Issue 1821103002: Migrate a bunch of LayoutTests from NPAPI to PPAPI

Unified Diff: third_party/WebKit/LayoutTests/plugins/embed-attributes-setting.html

Issue 1821103002: Migrate a bunch of LayoutTests from NPAPI to PPAPI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_open-and-close-window-with-plugin

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/permissionclient/plugin-permission.html ('K') | « third_party/WebKit/LayoutTests/platform/linux/plugins/plugin-initiate-popup-window-expected.txt ('k') | third_party/WebKit/LayoutTests/plugins/embed-attributes-setting-expected.txt » ('j') | third_party/WebKit/LayoutTests/plugins/no-mime-with-valid-extension.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/plugins/embed-attributes-setting.html

diff --git a/third_party/WebKit/LayoutTests/plugins/embed-attributes-setting.html b/third_party/WebKit/LayoutTests/plugins/embed-attributes-setting.html

index e86af51bd150e557721d2fcd44cc68d44075e371..003f8d77f58914b08f76cc1bc04736a4c12f2ef6 100644

--- a/third_party/WebKit/LayoutTests/plugins/embed-attributes-setting.html

+++ b/third_party/WebKit/LayoutTests/plugins/embed-attributes-setting.html

@@ -48,7 +48,7 @@ function test()

shouldBe("embed.getAttribute('width')", 1);

shouldBe("embed.getAttribute('type')", 1);

shouldBe("embed.getAttribute('src')", 1);

- shouldBe("typeof embed.testCallback", "function");

+ shouldBe("typeof embed.testPassTestObject", "function");

dcheng 2016/03/22 18:03:05 Similarly, can we use a message listener + the non

piman 2016/03/23 05:30:24 used "regular" plugin and postMessage here too.

print("----------");

@@ -56,9 +56,9 @@ function test()

print("[Embed is dynamically created element with only type specified]");

embed.style.visibility = "hidden";

- embed.type = "application/x-webkit-test-netscape";

+ embed.type = "application/x-blink-deprecated-test-plugin";

document.body.appendChild(embed);

- shouldBe("typeof embed.testCallback", "function");

+ shouldBe("typeof embed.testPassTestObject", "function");

print("----------");

@@ -66,9 +66,9 @@ function test()

print("[Embed is dynamically created element with only src specified]");

embed.style.visibility = "hidden";

- embed.src = "resources/test.testnetscape";

+ embed.src = "resources/test.blinktestplugin";

document.body.appendChild(embed);

- shouldBe("typeof embed.testCallback", "function");

+ shouldBe("typeof embed.testPassTestObject", "function");

}

</script>

</head>

@@ -78,7 +78,7 @@ function test()

<hr>

-<embed style="visibility: hidden" type="application/x-webkit-test-netscape" id='embed'></embed>

+<embed style="visibility: hidden" type="application/x-blink-deprecated-test-plugin" id='embed'></embed>

</body>

</html>