Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1821093002: - Ensure to patch all newly added external methods in dart2js. (Closed)

Created:
4 years, 9 months ago by Ivan Posva
Modified:
4 years, 9 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Ensure to patch all newly added external methods in dart2js. BUG= Committed: https://github.com/dart-lang/sdk/commit/69744a3acc43a60fa7de10ee6c061c22194a0af8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M sdk/lib/_internal/js_runtime/lib/io_patch.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Ivan Posva
TBR
4 years, 9 months ago (2016-03-22 00:02:58 UTC) #2
Ivan Posva
Committed patchset #1 (id:1) manually as 69744a3acc43a60fa7de10ee6c061c22194a0af8 (presubmit successful).
4 years, 9 months ago (2016-03-22 00:03:24 UTC) #4
zra
4 years, 9 months ago (2016-03-22 02:11:45 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698