Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: mojo/public/tools/bindings/mojom.gni

Issue 1821073002: Mojo bindings: Fix typemap includes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/mojom.gni
diff --git a/mojo/public/tools/bindings/mojom.gni b/mojo/public/tools/bindings/mojom.gni
index fb31385d7d903ccef9e41096dc189bd105a61268..ba00b6dd6da60b4f593acc608893384a59b88630 100644
--- a/mojo/public/tools/bindings/mojom.gni
+++ b/mojo/public/tools/bindings/mojom.gni
@@ -209,17 +209,22 @@ template("mojom") {
all_deps += invoker.public_deps
}
- group("${target_name}__is_mojom") {
+ if (defined(invoker.variant)) {
+ variant_suffix = "of_variant_${invoker.variant}"
+ } else {
+ variant_suffix = "of_no_variant"
+ }
+ group("${target_name}__is_mojom_${variant_suffix}") {
}
# Explicitly ensure that all dependencies (invoker.deps and
- # invoker.public_deps) are mojom targets themselves.
- group("${target_name}__check_deps_are_all_mojom") {
+ # invoker.public_deps) are mojom targets of the same variant themselves.
+ group("${target_name}__check_deps_are_all_mojom_${variant_suffix}") {
deps = []
foreach(d, all_deps) {
name = get_label_info(d, "label_no_toolchain")
toolchain = get_label_info(d, "toolchain")
- deps += [ "${name}__is_mojom(${toolchain})" ]
+ deps += [ "${name}__is_mojom_${variant_suffix}(${toolchain})" ]
}
}
@@ -235,6 +240,7 @@ template("mojom") {
testonly = invoker.testonly
}
sources = process_file_template(invoker.sources, generator_cpp_outputs)
+
deps = [
":$generator_target_name",
"//mojo/public/interfaces/bindings:bindings__generator",
@@ -242,9 +248,6 @@ template("mojom") {
public_deps = [
"//base",
]
- if (defined(invoker.typemap_deps)) {
- public_deps += invoker.typemap_deps
- }
foreach(d, all_deps) {
# Resolve the name, so that a target //mojo/something becomes
# //mojo/something:something and we can append cpp_sources_suffix to

Powered by Google App Engine
This is Rietveld 408576698