mojo/public/cpp/bindings/tests/BUILD.gn - Issue 1821073002: Mojo bindings: Fix typemap includes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/BUILD.gn

Issue 1821073002: Mojo bindings: Fix typemap includes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/tests/BUILD.gn

diff --git a/mojo/public/cpp/bindings/tests/BUILD.gn b/mojo/public/cpp/bindings/tests/BUILD.gn

index 00693e0a539496f8d494652356ca77fd310aa98d..c6c51be95aa1191f3ff7fb7fa68d4700d6e7127a 100644

--- a/mojo/public/cpp/bindings/tests/BUILD.gn

+++ b/mojo/public/cpp/bindings/tests/BUILD.gn

@@ -34,9 +34,8 @@ source_set("tests") {

"pickled_struct_chromium.cc",

"pickled_struct_chromium.h",

- # TODO: crbug.com/596202

- #"rect_blink.h",

- #"rect_chromium.h",

+ "rect_blink.h",

+ "rect_chromium.h",

yzshen1 2016/03/22 20:29:13 Please also make corresponding changes to mojo_edk

Sam McNally 2016/03/22 21:54:30 Done.

"request_response_unittest.cc",

"router_test_util.cc",

"router_test_util.h",

@@ -46,10 +45,12 @@ source_set("tests") {

"stl_converters_unittest.cc",

"string_unittest.cc",

- #"struct_traits_unittest.cc",

+ "struct_traits_unittest.cc",

"struct_unittest.cc",

"struct_with_traits_impl.cc",

"struct_with_traits_impl.h",

+ "struct_with_traits_impl_traits.cc",

+ "struct_with_traits_impl_traits.h",

yzshen1 2016/03/22 20:29:13 Why we include "struct_with_traits_impl_traits.*"

Sam McNally 2016/03/22 21:54:30 Done.

"sync_method_unittest.cc",

"type_conversion_unittest.cc",

"union_unittest.cc",