Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1820963002: Version 4.9.385.31 (cherry-pick) (Closed)

Created:
4 years, 9 months ago by Camillo Bruni
Modified:
4 years, 9 months ago
CC:
Paweł Hajdan Jr., ulan, v8-merges_googlegroups.com, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@4.9
Target Ref:
refs/pending/branch-heads/4.9
Project:
v8
Visibility:
Public.

Description

Version 4.9.385.31 (cherry-pick) Merged 96a2bd8ae8c25e2acbe63319011cbb829b59e3df [builtins] Fix Array.prototype.concat bug BUG=chromium:594574 LOG=N R=jkummerow@chromium.org, hablich@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/aa3be3bf89f67feac2f51c5fe9763c645454d445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -35 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.cc View 10 chunks +47 lines, -34 lines 0 comments Download
M src/elements.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/elements.cc View 4 chunks +37 lines, -0 lines 0 comments Download
M test/mjsunit/array-concat.js View 1 chunk +13 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-594574-concat-leak-1.js View 1 chunk +36 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-594574-concat-leak-2.js View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Camillo Bruni
4 years, 9 months ago (2016-03-21 16:20:51 UTC) #1
Camillo Bruni
4 years, 9 months ago (2016-03-21 16:29:05 UTC) #3
Jakob Kummerow
rubberstamp LGTM
4 years, 9 months ago (2016-03-21 16:32:49 UTC) #4
Camillo Bruni
4 years, 9 months ago (2016-03-21 16:47:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aa3be3bf89f67feac2f51c5fe9763c645454d445.

Powered by Google App Engine
This is Rietveld 408576698