Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: content/browser/site_per_process_browsertest.cc

Issue 1820953002: Disabling flaky SitePerProcessBrowserTest.SubframeKeyboardEventRouting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/site_per_process_browsertest.h" 5 #include "content/browser/site_per_process_browsertest.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 4869 matching lines...) Expand 10 before | Expand all | Expand 10 after
4880 // main frame. 4880 // main frame.
4881 SendGestureTapSequenceWithExpectedTarget(rwhv_parent, main_frame_point, 4881 SendGestureTapSequenceWithExpectedTarget(rwhv_parent, main_frame_point,
4882 router->gesture_target_, rwhv_child, 4882 router->gesture_target_, rwhv_child,
4883 rwhv_parent); 4883 rwhv_parent);
4884 EXPECT_EQ(0LU, router->gesture_target_queue_.size()); 4884 EXPECT_EQ(0LU, router->gesture_target_queue_.size());
4885 EXPECT_EQ(rwhv_parent, router->gesture_target_); 4885 EXPECT_EQ(rwhv_parent, router->gesture_target_);
4886 } 4886 }
4887 #endif // defined(USE_AURA) 4887 #endif // defined(USE_AURA)
4888 4888
4889 // Ensure that a cross-process subframe can receive keyboard events when in 4889 // Ensure that a cross-process subframe can receive keyboard events when in
4890 // focus. 4890 // focus. Flaky: https://crbug.com/596508.
4891 IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, 4891 IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
4892 SubframeKeyboardEventRouting) { 4892 DISABLED_SubframeKeyboardEventRouting) {
4893 GURL main_url(embedded_test_server()->GetURL( 4893 GURL main_url(embedded_test_server()->GetURL(
4894 "a.com", "/frame_tree/page_with_one_frame.html")); 4894 "a.com", "/frame_tree/page_with_one_frame.html"));
4895 EXPECT_TRUE(NavigateToURL(shell(), main_url)); 4895 EXPECT_TRUE(NavigateToURL(shell(), main_url));
4896 4896
4897 WebContentsImpl* web_contents = 4897 WebContentsImpl* web_contents =
4898 static_cast<WebContentsImpl*>(shell()->web_contents()); 4898 static_cast<WebContentsImpl*>(shell()->web_contents());
4899 FrameTreeNode* root = web_contents->GetFrameTree()->root(); 4899 FrameTreeNode* root = web_contents->GetFrameTree()->root();
4900 4900
4901 GURL frame_url( 4901 GURL frame_url(
4902 embedded_test_server()->GetURL("b.com", "/page_with_input_field.html")); 4902 embedded_test_server()->GetURL("b.com", "/page_with_input_field.html"));
(...skipping 1234 matching lines...) Expand 10 before | Expand all | Expand 10 after
6137 EXPECT_EQ(b_url, root->current_url()); 6137 EXPECT_EQ(b_url, root->current_url());
6138 6138
6139 // Verify that the same RenderViewHost is preserved and that it is no longer 6139 // Verify that the same RenderViewHost is preserved and that it is no longer
6140 // in swapped out state. 6140 // in swapped out state.
6141 EXPECT_EQ(rvh, contents->GetFrameTree()->GetRenderViewHost( 6141 EXPECT_EQ(rvh, contents->GetFrameTree()->GetRenderViewHost(
6142 root->current_frame_host()->GetSiteInstance())); 6142 root->current_frame_host()->GetSiteInstance()));
6143 EXPECT_FALSE(rvh->is_swapped_out_); 6143 EXPECT_FALSE(rvh->is_swapped_out_);
6144 } 6144 }
6145 6145
6146 } // namespace content 6146 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698