Add Ignition to about:flags.

Add Ignition to about:flags.

We are at the point where we would like to start experimenting with the Ignition
interpreter on real web pages. Adding this to about:flags makes this easier.

Design Doc: https://docs.google.com/document/d/11T2CRex9hXxoJwbYqVQ32yIPMh0uouUZLdyrtmMoL44

BUG=594228, v8:4280, v8:4868
Committed: https://crrev.com/fe515adb0e0bab62cafd8bfb6dc09df848a27d90
Cr-Commit-Position: refs/heads/master@{#386125}

[rmcilroy, 2016-03-21 16:55:56]

Patchset #1 (id:1) has been deleted

[rmcilroy, 2016-03-21 16:56:07]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-21 16:56:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820933002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820933002/20001

[rmcilroy, 2016-03-21 16:58:15]

rmcilroy@chromium.org changed reviewers:
+ jochen@chromium.org, jwd@chromium.org

[rmcilroy, 2016-03-21 16:58:16]

jochen@: PTAL at the about:flag changes.
jwd@: PTAL at histograms.xml changes.

Thanks.

[commit-bot: I haz the power, 2016-03-21 18:35:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 18:35:22]

Dry run: This issue passed the CQ dry run.

[jwd, 2016-03-23 18:51:21]

LGTM for histograms, Have you thought about using the feature api to control
this? go/feature-api.

[jochen (gone - plz use gerrit), 2016-03-24 14:43:41]

https://codereview.chromium.org/1820933002/diff/20001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1820933002/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:5659: +        Experimental Ignition
Interpreter
maybe JavaScript instead of Ignition? also in the desc="" field - translators
will have no idea what this is

https://codereview.chromium.org/1820933002/diff/20001/chrome/renderer/chrome_...
File chrome/renderer/chrome_render_process_observer.cc (right):

https://codereview.chromium.org/1820933002/diff/20001/chrome/renderer/chrome_...
chrome/renderer/chrome_render_process_observer.cc:261:
v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));
the proxy and pdfium will run without ignition then, is that what you intend to
do?

[rmcilroy, 2016-03-24 15:42:23]

Description was changed from

==========
Add Ignition to about:flags.

We are at the point where we would like to start experimenting with the Ignition
interpreter on real web pages. Adding this to about:flags makes this easier.

Design Doc:
https://docs.google.com/document/d/11T2CRex9hXxoJwbYqVQ32yIPMh0uouUZLdyrtmMoL44

BUG=594228, v8:4280
==========

to

==========
Add Ignition to about:flags.

We are at the point where we would like to start experimenting with the Ignition
interpreter on real web pages. Adding this to about:flags makes this easier.

Design Doc:
https://docs.google.com/document/d/11T2CRex9hXxoJwbYqVQ32yIPMh0uouUZLdyrtmMoL44

BUG=594228, v8:4280, v8:4868
==========

[rmcilroy, 2016-03-24 15:46:47]

https://codereview.chromium.org/1820933002/diff/20001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1820933002/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:5659: +        Experimental Ignition
Interpreter
On 2016/03/24 14:43:41, jochen - slow wrote:
> maybe JavaScript instead of Ignition? also in the desc="" field - translators
> will have no idea what this is

Done.

https://codereview.chromium.org/1820933002/diff/20001/chrome/renderer/chrome_...
File chrome/renderer/chrome_render_process_observer.cc (right):

https://codereview.chromium.org/1820933002/diff/20001/chrome/renderer/chrome_...
chrome/renderer/chrome_render_process_observer.cc:261:
v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));
On 2016/03/24 14:43:41, jochen - slow wrote:
> the proxy and pdfium will run without ignition then, is that what you intend
to
> do?

I'm not too worried about this being used for proxy PAC files, but it might be
nice to enable it for pdfium. Could you recommend the best place to set this
flag for pdfium?

[rmcilroy, 2016-03-24 15:47:21]

> Have you thought about using the feature api to control
> this? go/feature-api.

Even better - didn't know about this option. Done.

[jochen (gone - plz use gerrit), 2016-03-30 16:13:34]

https://codereview.chromium.org/1820933002/diff/40001/chrome/renderer/chrome_...
File chrome/renderer/chrome_render_process_observer.cc (right):

https://codereview.chromium.org/1820933002/diff/40001/chrome/renderer/chrome_...
chrome/renderer/chrome_render_process_observer.cc:267:
v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));
you could move this to gin/isolate_holder.cc - then it will be applied
everywhere

[Alexei Svitkine (slow), 2016-03-30 17:02:44]

asvitkine@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-03-30 17:02:45]

https://codereview.chromium.org/1820933002/diff/40001/chrome/renderer/chrome_...
File chrome/renderer/chrome_render_process_observer.cc (right):

https://codereview.chromium.org/1820933002/diff/40001/chrome/renderer/chrome_...
chrome/renderer/chrome_render_process_observer.cc:267:
v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));
On 2016/03/30 16:13:34, jochen - slow wrote:
> you could move this to gin/isolate_holder.cc - then it will be applied
> everywhere

Unfortunately, this is not possible currently due to http://crbug.com/599165

I'll be working on resolving that, but for now it can't be done from there.

[rmcilroy, 2016-04-08 10:57:36]

On 2016/03/30 17:02:45, Alexei Svitkine wrote:
>
https://codereview.chromium.org/1820933002/diff/40001/chrome/renderer/chrome_...
> File chrome/renderer/chrome_render_process_observer.cc (right):
> 
>
https://codereview.chromium.org/1820933002/diff/40001/chrome/renderer/chrome_...
> chrome/renderer/chrome_render_process_observer.cc:267:
> v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));
> On 2016/03/30 16:13:34, jochen - slow wrote:
> > you could move this to gin/isolate_holder.cc - then it will be applied
> > everywhere
> 
> Unfortunately, this is not possible currently due to http://crbug.com/599165
> 
> I'll be working on resolving that, but for now it can't be done from there.

Thanks for the heads up. Looks like this has been addressed for Gin after
https://codereview.chromium.org/1848523002/ landed.

I've updated the change to move the feature to Gin and add the flag there, which
seems to set it for pdfium and the browser too. Jochen - PTAL, thanks.

[Alexei Svitkine (slow), 2016-04-08 15:12:42]

Are you missing the gin_features.cc file?

https://codereview.chromium.org/1820933002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1820933002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:74660: +  <int value="-896238580"
label="enable-ignition"/>
This is not necessary when using feature api.

[rmcilroy, 2016-04-08 15:53:05]

> Are you missing the gin_features.cc file?

Opps, missed this. Added, thanks.

https://codereview.chromium.org/1820933002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1820933002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:74660: +  <int value="-896238580"
label="enable-ignition"/>
On 2016/04/08 15:12:42, Alexei Svitkine wrote:
> This is not necessary when using feature api.

Done.

[rmcilroy, 2016-04-08 15:53:09]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 15:53:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820933002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820933002/80001

[jochen (gone - plz use gerrit), 2016-04-08 15:59:29]

lgtm

[commit-bot: I haz the power, 2016-04-08 16:21:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 16:21:22]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[rmcilroy, 2016-04-08 16:54:32]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-04-08 16:54:33]

The patchset sent to the CQ was uploaded after l-g-t-m from jwd@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1820933002/#ps100001
(title: "Fix GIN_EXPORT")

[commit-bot: I haz the power, 2016-04-08 16:54:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820933002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820933002/100001

[commit-bot: I haz the power, 2016-04-08 17:59:34]

Description was changed from

==========
Add Ignition to about:flags.

We are at the point where we would like to start experimenting with the Ignition
interpreter on real web pages. Adding this to about:flags makes this easier.

Design Doc:
https://docs.google.com/document/d/11T2CRex9hXxoJwbYqVQ32yIPMh0uouUZLdyrtmMoL44

BUG=594228, v8:4280, v8:4868
==========

to

==========
Add Ignition to about:flags.

We are at the point where we would like to start experimenting with the Ignition
interpreter on real web pages. Adding this to about:flags makes this easier.

Design Doc:
https://docs.google.com/document/d/11T2CRex9hXxoJwbYqVQ32yIPMh0uouUZLdyrtmMoL44

BUG=594228, v8:4280, v8:4868
==========

[commit-bot: I haz the power, 2016-04-08 17:59:35]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-04-08 18:01:36]

Description was changed from

==========
Add Ignition to about:flags.

We are at the point where we would like to start experimenting with the Ignition
interpreter on real web pages. Adding this to about:flags makes this easier.

Design Doc:
https://docs.google.com/document/d/11T2CRex9hXxoJwbYqVQ32yIPMh0uouUZLdyrtmMoL44

BUG=594228, v8:4280, v8:4868
==========

to

==========
Add Ignition to about:flags.

We are at the point where we would like to start experimenting with the Ignition
interpreter on real web pages. Adding this to about:flags makes this easier.

Design Doc:
https://docs.google.com/document/d/11T2CRex9hXxoJwbYqVQ32yIPMh0uouUZLdyrtmMoL44

BUG=594228, v8:4280, v8:4868

Committed: https://crrev.com/fe515adb0e0bab62cafd8bfb6dc09df848a27d90
Cr-Commit-Position: refs/heads/master@{#386125}
==========

[commit-bot: I haz the power, 2016-04-08 18:01:37]

Patchset 5 (id:??) landed as
https://crrev.com/fe515adb0e0bab62cafd8bfb6dc09df848a27d90
Cr-Commit-Position: refs/heads/master@{#386125}