Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1505)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 182093002: Remove the flash specific disk cache backend. (Closed)

Created:
6 years, 9 months ago by gavinp
Modified:
6 years, 9 months ago
Reviewers:
agayev2, davidben
CC:
chromium-reviews, kalyank, cbentzel+watch_chromium.org, sadrul, gavinp+disk_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Remove the flash specific disk cache backend. This disk cache backend is no longer under development. R=davidben@chromium.org,agayev@gmail.com TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1769 lines) Patch
D net/disk_cache/flash/flash_cache_test_base.h View 1 chunk +0 lines, -43 lines 0 comments Download
D net/disk_cache/flash/flash_cache_test_base.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D net/disk_cache/flash/flash_entry_impl.h View 1 chunk +0 lines, -98 lines 0 comments Download
D net/disk_cache/flash/flash_entry_impl.cc View 1 chunk +0 lines, -150 lines 0 comments Download
D net/disk_cache/flash/format.h View 1 chunk +0 lines, -32 lines 0 comments Download
D net/disk_cache/flash/internal_entry.h View 1 chunk +0 lines, -63 lines 0 comments Download
D net/disk_cache/flash/internal_entry.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D net/disk_cache/flash/log_store.h View 1 chunk +0 lines, -101 lines 0 comments Download
D net/disk_cache/flash/log_store.cc View 1 chunk +0 lines, -185 lines 0 comments Download
D net/disk_cache/flash/log_store_entry.h View 1 chunk +0 lines, -65 lines 0 comments Download
D net/disk_cache/flash/log_store_entry.cc View 1 chunk +0 lines, -171 lines 0 comments Download
D net/disk_cache/flash/log_store_entry_unittest.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D net/disk_cache/flash/log_store_unittest.cc View 1 chunk +0 lines, -131 lines 0 comments Download
D net/disk_cache/flash/segment.h View 1 chunk +0 lines, -118 lines 0 comments Download
D net/disk_cache/flash/segment.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D net/disk_cache/flash/segment_unittest.cc View 1 chunk +0 lines, -152 lines 0 comments Download
D net/disk_cache/flash/storage.h View 1 chunk +0 lines, -35 lines 0 comments Download
D net/disk_cache/flash/storage.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D net/disk_cache/flash/storage_unittest.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M net/net.gyp View 3 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
gavinp
davidben: PTAL. agayev: FYI. This issue is downstream of https://codereview.chromium.org/121643003/ , and it's just removing ...
6 years, 9 months ago (2014-02-26 20:16:57 UTC) #1
davidben
Assuming this compiles and such, LGTM.
6 years, 9 months ago (2014-02-26 20:24:20 UTC) #2
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 9 months ago (2014-02-26 20:56:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/182093002/1
6 years, 9 months ago (2014-02-26 20:57:21 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-26 21:34:37 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 9 months ago (2014-02-26 21:34:38 UTC) #6
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 9 months ago (2014-03-05 16:30:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/182093002/1
6 years, 9 months ago (2014-03-05 16:32:06 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 17:03:44 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275336
6 years, 9 months ago (2014-03-05 17:03:45 UTC) #10
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 9 months ago (2014-03-05 17:04:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/182093002/1
6 years, 9 months ago (2014-03-05 17:05:58 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 19:27:10 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275470
6 years, 9 months ago (2014-03-05 19:27:11 UTC) #14
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 9 months ago (2014-03-05 21:46:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/182093002/1
6 years, 9 months ago (2014-03-05 21:50:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/182093002/1
6 years, 9 months ago (2014-03-06 00:02:45 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 01:53:31 UTC) #18
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275920
6 years, 9 months ago (2014-03-06 01:53:32 UTC) #19
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 9 months ago (2014-03-06 15:56:32 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/182093002/1
6 years, 9 months ago (2014-03-06 16:01:04 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 18:30:51 UTC) #22
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=276396
6 years, 9 months ago (2014-03-06 18:30:51 UTC) #23
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 9 months ago (2014-03-06 18:35:10 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/182093002/1
6 years, 9 months ago (2014-03-06 18:39:05 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/182093002/1
6 years, 9 months ago (2014-03-06 20:56:18 UTC) #26
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 21:28:05 UTC) #27
Message was sent while issue was closed. 
Change committed as 255433

Powered by Google App Engine
This is Rietveld 408576698