testing_support: fix Gerrit releases URL.

testing_support: fix Gerrit releases URL.

R=szager@chromium.org,sergiyb@chromium.org
BUG=579160
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299408

[tandrii(chromium), 2016-03-21 15:53:51]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[tandrii(chromium), 2016-03-21 15:53:56]

The CQ bit was unchecked by tandrii@chromium.org

[tandrii(chromium), 2016-03-21 15:54:34]

PTAL

Stephan, is that a good idea to use this OR would you rather recommend to burn
this code with fire?

[szager1, 2016-03-21 16:55:38]

On 2016/03/21 15:54:34, tandrii(chromium) wrote:
> PTAL
> 
> Stephan, is that a good idea to use this OR would you rather recommend to burn
> this code with fire?

It used to be the case that tests using this script were the only test coverage
we had to test infra code against the most recent version of gerrit.  I have no
idea if those tests are still running or not.

At some point, the gerrit team started running the chromite tests against their
staging server before they pushed to production (dborowitz knows more about
this).  If that's still happening, then it's good protection against breaking
gerrit changes, but it doesn't provide coverage against breaking chrome infra
changes.

So... up to you, really.  In my opinion, it's prudent to have test coverage to
prevent chrome infra changes from breaking due to incompatibilities with gerrit.

[Sergiy Byelozyorov, 2016-03-21 16:56:35]

lgtm

[Sergiy Byelozyorov, 2016-03-21 16:57:15]

On 2016/03/21 16:56:35, Sergiy Byelozyorov wrote:
> lgtm

https://memegen.googleplex.com/5386850802860032

[tandrii(chromium), 2016-03-21 16:59:42]

On 2016/03/21 16:55:38, szager1 wrote:
> On 2016/03/21 15:54:34, tandrii(chromium) wrote:
> > PTAL
> > 
> > Stephan, is that a good idea to use this OR would you rather recommend to
burn
> > this code with fire?
> 
> It used to be the case that tests using this script were the only test
coverage
> we had to test infra code against the most recent version of gerrit.  I have
no
> idea if those tests are still running or not.
> 
> At some point, the gerrit team started running the chromite tests against
their
> staging server before they pushed to production (dborowitz knows more about
> this).  If that's still happening, then it's good protection against breaking
> gerrit changes, but it doesn't provide coverage against breaking chrome infra
> changes.
I see. ACtually they stopped just last week or so. But it'd like to ensure some
end-to-end testing of "git cl *". I so far ended up with end-to-end recipe, but
it's working with real gerrit. Example:
https://build.chromium.org/p/tryserver.infra/builders/Try%20Recipe%20Mac/buil...

I think I'll consider resurrecting this for faster standalone depot_tools tests.

> 
> So... up to you, really.  In my opinion, it's prudent to have test coverage to
> prevent chrome infra changes from breaking due to incompatibilities with
gerrit.

[tandrii(chromium), 2016-03-21 16:59:45]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-03-21 16:59:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820923002/1

[commit-bot: I haz the power, 2016-03-21 17:02:13]

Description was changed from

==========
testing_support: fix Gerrit releases URL.

R=szager@chromium.org,sergiyb@chromium.org
BUG=579160
==========

to

==========
testing_support: fix Gerrit releases URL.

R=szager@chromium.org,sergiyb@chromium.org
BUG=579160

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299408
==========

[commit-bot: I haz the power, 2016-03-21 17:02:15]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299408

[szager1, 2016-03-21 17:18:58]

https://codereview.chromium.org/1820923002/diff/1/testing_support/gerrit-init.sh
File testing_support/gerrit-init.sh (right):

https://codereview.chromium.org/1820923002/diff/1/testing_support/gerrit-init...
testing_support/gerrit-init.sh:80: # Disable using -rc versions.  This is a
temporary hack to avoid
Maybe it's time to check whether this hack can be removed?

[tandrii(chromium), 2016-03-22 15:33:58]

On 2016/03/21 17:18:58, szager1 wrote:
>
https://codereview.chromium.org/1820923002/diff/1/testing_support/gerrit-init.sh
> File testing_support/gerrit-init.sh (right):
> 
>
https://codereview.chromium.org/1820923002/diff/1/testing_support/gerrit-init...
> testing_support/gerrit-init.sh:80: # Disable using -rc versions.  This is a
> temporary hack to avoid
> Maybe it's time to check whether this hack can be removed?
filed http://crbug.com/596905 - won't waste time, unless I actually start using
gerrit. Otherwise, I'll wipe this whole thing out of depot_tools.