Issue 1820913003: Increased Canvas size for the CircleLayerDelegate that is used for MD ripples.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1820913003: Increased Canvas size for the CircleLayerDelegate that is used for MD ripples. (Closed)

Created:
4 years, 9 months ago by bruthig

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

Increased Canvas size for the CircleLayerDelegate that is used for MD ripples. The Bookmark ripple was getting clipped on devices with a 2x scale factor due to the Canvas not being large enough. BUG=594243 TEST=manual Review URL: https://codereview.chromium.org/1806563002 Cr-Commit-Position: refs/heads/master@{#381232} (cherry picked from commit ce72fa9b7010a4c72b9363469087444ec4f77792) Committed: https://chromium.googlesource.com/chromium/src/+/fb7744700843d05e454194457279d77c0e9f2572

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ui/views/animation/ink_drop_painted_layer_delegates.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

bruthig

4 years, 9 months ago (2016-03-21 17:38:05 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fb7744700843d05e454194457279d77c0e9f2572.