Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 1820903005: Fixes cc_blink_unittests in a better way. (Closed)

Created:
4 years, 9 months ago by Yuki
Modified:
4 years, 9 months ago
Reviewers:
brettw, jam
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes cc_blink_unittests in a better way. This is a better version of the fix of http://crrev.com/1737873002 We should add "blink_for_unittests" to "cc_blink_unittests" rather than "cc_blink". BUG=589949 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/22c03d9a0b8e15c7018b8b02225a0fe34b73e850 Cr-Commit-Position: refs/heads/master@{#382800}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M cc/blink/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Yuki
Could you guys review this CL?
4 years, 9 months ago (2016-03-22 11:41:11 UTC) #4
jam
lgtm
4 years, 9 months ago (2016-03-22 15:35:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820903005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820903005/20001
4 years, 9 months ago (2016-03-23 05:52:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-23 06:40:46 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 06:42:12 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/22c03d9a0b8e15c7018b8b02225a0fe34b73e850
Cr-Commit-Position: refs/heads/master@{#382800}

Powered by Google App Engine
This is Rietveld 408576698